GH-1158: Fix inclusive bounds checking for DictionaryDecoder - #1159
Open
jakobhok-neo4j wants to merge 1 commit into
Open
GH-1158: Fix inclusive bounds checking for DictionaryDecoder#1159jakobhok-neo4j wants to merge 1 commit into
jakobhok-neo4j wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
jakobhok-neo4j
marked this pull request as ready for review
May 19, 2026 06:34
jakobhok-neo4j
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
May 19, 2026 06:34
This comment has been minimized.
lidavidm
reviewed
Aug 25, 2026
lidavidm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Seems reasonable. Can you rebase to pick up CI fixes?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Could use assertThrows for new tests?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1158.