MINOR: Change access modifier of StructVector reallocValidityBuffer - #1195
MINOR: Change access modifier of StructVector reallocValidityBuffer#1195lriggs wants to merge 1 commit into
Conversation
Sorry, something went wrong.
…vate to protected. This allows subclasses to reallocate the validity buffer independently of the struct elements. Previously, expanding the validity buffer required a full vector reallocation, which could cause an OversizedAllocationException if the child data vectors were already near their capacity.
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Sorry, something went wrong.
|
What's the use case for subclassing StructVector? |
Sorry, something went wrong.
We have a helper class which wraps StructVector to provide more fine grained control. Maybe @selvaganesang can provide some more details. |
Sorry, something went wrong.
|
Provides a mechanism for independent reallocation of embedded vectors to prevent over-expansion of variable-width vectors when the parent struct vector is reallocated. This only mimics the similar concept from ListVector. |
Sorry, something went wrong.
|
I suppose, why can't the improvements themselves be upstreamed? |
Sorry, something went wrong.
What's Changed
Changes the access modifier of reallocValidityBuffer from package-private to protected.
This allows subclasses to reallocate the validity buffer independently of the struct elements. Previously, expanding the validity buffer required a full vector reallocation, which could cause an OversizedAllocationException if the child data vectors were already near their capacity.