GH-559: [Java] Add FixedSizeBinary support to ComplexCopier - #1253
Open
Maria-Berta wants to merge 3 commits into
Open
GH-559: [Java] Add FixedSizeBinary support to ComplexCopier#1253Maria-Berta wants to merge 3 commits into
Maria-Berta wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Maria-Berta
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
August 3, 2026 03:58
This comment has been minimized.
Copy link
Copy Markdown
Author
|
Hi @jbonofre @laurentgo @lidavidm @wgtmac — checking in on this PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ComplexCopier did not support copying FixedSizeBinary columns nested in List, Map, Struct, or top-level contexts, throwing UnsupportedOperationException.
What changes are included in this PR?
Adds FIXEDSIZEBINARY cases to:
Are these changes tested?
Yes:
Full TestComplexCopier suite (22 tests) passes with no regressions.
Note: I attempted to add equivalent coverage for Map values of type FixedSizeBinary, but ran into a pre-existing limitation unrelated to this fix — MapWriter/ListWriter's no-arg fixedSizeBinary() delegates to NullableStructWriter.fixedSizeBinary(String), which only looks up an existing child writer and never creates one. The byteWidth-aware overload that does create the vector isn't reachable through the public MapWriter/ListWriter interface. This appears to be a gap in the writer codegen itself rather than something ComplexCopier can work around, so I've left it untested here — happy to open a follow-up issue if that's useful, or take a stab at it if maintainers think it's in scope for this PR.
Closes #559