FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-19: Add CONTRIBUTING.md by wgtmac · Pull Request #35 · apache/arrow-java · GitHub

/ arrow-java Public

GH-19: Add CONTRIBUTING.md - #35

Merged
raulcd merged 2 commits into
apache:mainfrom
wgtmac:contrib
Nov 25, 2024
ConversationCommits (2)ChecksFiles changed
Merged

GH-19: Add CONTRIBUTING.md#35
raulcd merged 2 commits into
apache:mainfrom
wgtmac:contrib

Conversation

wgtmac commented Nov 25, 2024

Copy link
Copy Markdown
Member

Closes #19

raulcd approved these changes Nov 25, 2024
View reviewed changes

raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread CONTRIBUTING.md Outdated
Update CONTRIBUTING.md
54cfa50 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
raulcd merged commit 9e5bed4 into apache:main Nov 25, 2024

wgtmac commented Nov 25, 2024

Copy link
Copy Markdown
Member Author

Thank you @raulcd!

kou commented Nov 26, 2024

Copy link
Copy Markdown
Member

Do we want to use GH-XXX: prefix like apache/arrow in apache/arrow-java too?

FYI: apache/arrow-go uses Conventional Commits. See also: https://github.com/apache/arrow-go/blob/main/CONTRIBUTING.md
(Sorry. I used a wrong URL in GH-19...)

wgtmac commented Nov 26, 2024

Copy link
Copy Markdown
Member Author

I'm open to either. (I haven't used conventional commits yet. Let me learn it first)

kou commented Nov 26, 2024

Copy link
Copy Markdown
Member

@lidavidm Do you have any opinion for this?

assignUser commented Nov 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

conventional commits will make it easy to calculate a proper semver automatically.

lidavidm added this to the 18.2.0 milestone Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

raulcd raulcd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.2.0

Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md

5 participants

Back | FazBrowse Home | New Git URL