FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-5: [Docs] Add LICENSE and NOTICE files by raulcd · Pull Request #39 · apache/arrow-java · GitHub

/ arrow-java Public

GH-5: [Docs] Add LICENSE and NOTICE files - #39

Merged
kou merged 7 commits into
apache:mainfrom
raulcd:GH-5
Nov 29, 2024
ConversationCommits (7)ChecksFiles changed
Merged

GH-5: [Docs] Add LICENSE and NOTICE files#39
kou merged 7 commits into
apache:mainfrom
raulcd:GH-5

Conversation

raulcd commented Nov 26, 2024

Copy link
Copy Markdown
Member

Closes #5

raulcd commented Nov 26, 2024

Copy link
Copy Markdown
Member Author

I've trimmed down and removed all dependencies that seem to refer to C++ / Python / and other implementations and left the ones that are related to Java (or seem to be related to Java).

raulcd marked this pull request as ready for review November 26, 2024 14:32
kou reviewed Nov 27, 2024
View reviewed changes
Comment thread NOTICE.txt Outdated
kou reviewed Nov 28, 2024
View reviewed changes
Comment thread LICENSE.txt Outdated
Comment thread LICENSE.txt
Comment thread LICENSE.txt Outdated
Comment on lines +211 to +216
--------------------------------------------------------------------------------

This product includes software from Dremio, which is made available under the
Apache License 2.0.
* Copyright (C) 2017-2018 Dremio Corporation
* https://github.com/dremio/dremio-oss

kou Nov 28, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems that we can remove this because we removed "Copyright (C) 2017-2018 Dremio Corporation" by apache/arrow#5602 .
Anyway, I should have asked why we can remove it when I merge...

raulcd Nov 28, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @kou ! I've removed it

raulcd commented Nov 28, 2024

Copy link
Copy Markdown
Member Author

I've rebased main but it seems pre-commit is failing there. I've opened:

kou reviewed Nov 29, 2024
View reviewed changes
Comment thread LICENSE.txt Outdated
kou approved these changes Nov 29, 2024
View reviewed changes

kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1

kou merged commit 55fced5 into apache:main Nov 29, 2024
lidavidm added this to the 18.2.0 milestone Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kou kou approved these changes
assignUser assignUser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.2.0

Development

Successfully merging this pull request may close these issues.

Add LICENSE.txt and NOTICE

4 participants

Back | FazBrowse Home | New Git URL