FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-48: Implement VectorAppender for BaseVariableWidthViewVector by ViggoC · Pull Request #454 · apache/arrow-java · GitHub

/ arrow-java Public

GH-48: Implement VectorAppender for BaseVariableWidthViewVector - #454

Merged
lidavidm merged 3 commits into
apache:mainfrom
ViggoC:viggo/string-view-appender
Jan 22, 2025
ConversationCommits (3)ChecksFiles changed
Merged

GH-48: Implement VectorAppender for BaseVariableWidthViewVector#454
lidavidm merged 3 commits into
apache:mainfrom
ViggoC:viggo/string-view-appender

Conversation

ViggoC commented Dec 10, 2024 •
edited by lidavidm
Loading

Copy link
Copy Markdown
Contributor

Fixes #48.

ViggoC mentioned this pull request Dec 10, 2024
Closed
ViggoC force-pushed the viggo/string-view-appender branch from bfa1bcf to 5470deb Compare December 19, 2024 17:20
ViggoC marked this pull request as ready for review December 19, 2024 17:21
lidavidm reviewed Jan 10, 2025
View reviewed changes
Comment thread vector/src/test/java/org/apache/arrow/vector/util/TestVectorAppender.java

lidavidm Jan 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does this test the case of multiple data buffers?

ViggoC Jan 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You mean ViewVarCharVector.dataBuffers.size() > 1. I'm afraid not. I'll check it, and add a case if it's not covered.

ViggoC commented Jan 19, 2025
View reviewed changes
Comment thread vector/src/test/java/org/apache/arrow/vector/util/TestVectorAppender.java
VectorAppender appender = new VectorAppender(target);
delta.accept(appender, null);

assertEquals(2, target.getDataBuffers().size());

ViggoC Jan 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@lidavidm ViewVarCharVector.dataBuffers.size() > 1 is already covered in this test case.

lidavidm Jan 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But what about the cases where target and delta have more than one data buffer before appending?

ViggoC Jan 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's covered in e918540.

lidavidm merged commit db8b6aa into apache:main Jan 22, 2025
lidavidm added this to the 18.2.0 milestone Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lidavidm lidavidm approved these changes
laurentgo Awaiting requested review from laurentgo laurentgo is a code owner
wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.2.0

Development

Successfully merging this pull request may close these issues.

[Java] Implement VectorAppender for BaseVariableWidthViewVector

2 participants

Back | FazBrowse Home | New Git URL