GH-469: Unify ValueVector.getObject and VariableWidthFieldVector.get behavior about null value - #486
Merged
lidavidm merged 4 commits intoJan 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aqni
marked this pull request as draft
January 6, 2025 15:24
aqni
marked this pull request as ready for review
January 6, 2025 16:23
lidavidm
approved these changes
Jan 13, 2025
lidavidm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can you rebase? It appears CI didn't trigger
Sorry, something went wrong.
…vior about null value
This reverts commit 4ef7160.
Copy link
Copy Markdown
Member
|
Ah, my UI wasn't showing the approve button... |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Some jobs have failed, and the logs show that it seems to be a download timeout. Can you help me re-run the failed jobs? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good now. Any other review comments? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469.