GH-527: [Release] Add support for .jar for Windows - #528
Merged
kou merged 1 commit intoJan 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes apacheGH-527. It seems that arrow-testing with ARROW_BUILD_STATIC=ON and GTest_SOURCE=BUNDLED is broken. We'll enable JNI test after we fix it in apache/arrow.
Copy link
Copy Markdown
Member
Author
|
CI is green. |
Sorry, something went wrong.
wgtmac
approved these changes
Jan 17, 2025
wgtmac
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
+1
I just did a quick scan (but may not be able to spot any issue).
Sorry, something went wrong.
lidavidm
approved these changes
Jan 17, 2025
lidavidm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-527.
It seems that arrow-testing with ARROW_BUILD_STATIC=ON and GTest_SOURCE=BUNDLED is broken. We'll enable JNI test after we fix it in apache/arrow.