FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-470: ListViewVector#getElementEndIndex should returns size not index by joyCurry30 · Pull Request #554 · apache/arrow-java · GitHub

/ arrow-java Public

GH-470: ListViewVector#getElementEndIndex should returns size not index #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyCurry30 wants to merge 2 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 11 Commits 2 Checks 0 Files changed
Open

GH-470: ListViewVector#getElementEndIndex should returns size not index #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979d56f
[GH-470]ListViewVector#getElementEndIndex should returns size not index.
joyCurry30 Jan 23, 2025
fedcf04
[GH-470] Address comment.
joyCurry30 Mar 11, 2025
File filter

Filter by extension

Filter by extension .java  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ public int getElementStartIndex(int index) {

@Override
public int getElementEndIndex(int index) {
return sizeBuffer.getInt(index * OFFSET_WIDTH);
return offsetBuffer.getInt((index + 1) * OFFSET_WIDTH);

wgtmac Jan 24, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should line 954 be changed together? BTW, are these methods covered by any unit test?

wgtmac Jan 24, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To answer my 1st question: no.

nbauernfeind Jan 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't see any unit tests for it; and if possible would be worth a small one.

lidavidm Jan 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, the fact that tests passed means nothing's covering it. Unfortunately the new types were only partially implemented before the contributor left.

lidavidm Jan 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could add a few basic assertions to testBasicListViewVector https://github.com/apache/arrow-java/blob/main/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java

joyCurry30 Jan 27, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good suggest. I will add UT for it.

lidavidm Jan 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

lidavidm Mar 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shouldn't the end index be offset + size + 1? (Assuming noninclusive)
}

@Override
Expand Down
27 changes: 27 additions & 0 deletions vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2223,4 +2223,31 @@ private void writeIntValues(UnionListViewWriter writer, int[] values) {
}
writer.endListView();
}

@Test
public void testGetElementEndIndex() {
try (ListViewVector vector = ListViewVector.empty("list", allocator)) {
vector.allocateNew();

UnionListViewWriter writer = vector.getWriter();

writer.setPosition(0);
writer.startListView();
writer.integer().writeInt(1);
writer.integer().writeInt(2);
writer.endListView();

writer.setPosition(1);
writer.startListView();
writer.integer().writeInt(3);
writer.integer().writeInt(4);
writer.integer().writeInt(5);
writer.endListView();

vector.setValueCount(2);

assertEquals(2, vector.getElementEndIndex(0));
assertEquals(5, vector.getElementEndIndex(1));
}
}
}
Back | FazBrowse Home | New Git URL