FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts by jbonofre · Pull Request #578 · apache/arrow-java · GitHub

/ arrow-java Public

GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts - #578

Merged
lidavidm merged 1 commit into
apache:mainfrom
jbonofre:license-notice
Feb 5, 2025
ConversationCommits (1)ChecksFiles changed
Merged

GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts#578
lidavidm merged 1 commit into
apache:mainfrom
jbonofre:license-notice

Conversation

jbonofre commented Jan 31, 2025 •
edited by kou
Loading

Copy link
Copy Markdown
Member

Fixes #579.

In our distributed artifacts, especially the shading ones, we have to provide LICENSE.txt and NOTICE.txt with all "bundled" dependencies.

@lidavidm @kou This is a draft PR as I have to fix the non-shading artifacts.

jbonofre marked this pull request as draft January 31, 2025 13:08

jbonofre commented Jan 31, 2025

Copy link
Copy Markdown
Member Author

@kou @lidavidm if you have time, you can already take a look on the content. Please let me know if you have any question.

lidavidm commented Jan 31, 2025

Copy link
Copy Markdown
Member

BTW, how were these generated? Or do they have to be assembled by hand?

jbonofre commented Jan 31, 2025

Copy link
Copy Markdown
Member Author

BTW, how were these generated? Or do they have to be assembled by hand?

For this release, I did that "manually". After the release, I will add the maven tooling to at least check the content.

kou approved these changes Jan 31, 2025
View reviewed changes

kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1

Thanks!

kou changed the title Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts Feb 1, 2025
wgtmac reviewed Feb 2, 2025
View reviewed changes
Comment thread LICENSE.txt
--------------------------------------------------------------------------------
vector/src/main/java/org/apache/arrow/vector/util/IntObjectHashMap.java
vector/src/main/java/org/apache/arrow/vector/util/IntObjectMap.java
This product includes code from Netty 4.1.117.Final:

wgtmac Feb 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is it required to include the specific version? It would be easily out of sync since the dependabot does not maintain this.

jbonofre Feb 2, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unfortunately (or not 😄 ), yes, It's important to specify the version of the dependency as licenses sometimes change as product versions change.
Also the NOTICE can change from a version to another.
So, it's better to document to actual version bundled in our distributed jar.

So source distribution, we should document the version where the code has been copied from.

wgtmac Feb 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the explanation! If we don't have good automation tools to keep them in sync, at least we need to make sure they are accurate in the release process.

jbonofre commented Feb 2, 2025

Copy link
Copy Markdown
Member Author

I'm fixing the location and other jar resources.

kou commented Feb 3, 2025

Copy link
Copy Markdown
Member

Should we merge PRs from Dependabot such as #584 after the next release?
I think that they may change dependency versions in binary artifacts.

jbonofre commented Feb 3, 2025

Copy link
Copy Markdown
Member Author

Should we merge PRs from Dependabot such as #584 after the next release? I think that they may change dependency versions in binary artifacts.

We can merge dependabot PRs, I will update this PR accordingly. That's totally fine for me. I need ~ 1 day to fix the last "jar" creation.

kou commented Feb 3, 2025

Copy link
Copy Markdown
Member

OK. I'll merge the following PRs that were opened in this week:

Our Dependabot configuration uses "weekly". So the next PRs from Dependabot will be opened in the next week.

jbonofre commented Feb 4, 2025

Copy link
Copy Markdown
Member Author

@kou thanks ! I'm updating this PR accordingly.

jbonofre marked this pull request as ready for review February 4, 2025 10:10

jbonofre commented Feb 4, 2025

Copy link
Copy Markdown
Member Author

I'm fixing the endline thing.

kou commented Feb 5, 2025

Copy link
Copy Markdown
Member

@jbonofre Can we merge this?

jbonofre commented Feb 5, 2025

Copy link
Copy Markdown
Member Author

@jbonofre Can we merge this?

Yes, we are good 👍

lidavidm merged commit 993536f into apache:main Feb 5, 2025

jbonofre commented Feb 5, 2025

Copy link
Copy Markdown
Member Author

@lidavidm @kou thanks for the review and merge. I'm doing a quick new run but I think we are good for the release.

kou commented Feb 5, 2025

Copy link
Copy Markdown
Member

Thanks! I'll create cut an RC.

lidavidm added this to the 18.3.0 milestone Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wgtmac wgtmac approved these changes
kou kou approved these changes
lidavidm lidavidm approved these changes
laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.3.0

Development

Successfully merging this pull request may close these issues.

LICENSE.txt/NOTICE.txt miss dependencies for binary artifacts

4 participants

Back | FazBrowse Home | New Git URL