FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-588: [Release] Increase wait interval in `dev/release/release_rc.sh` by kou · Pull Request #589 · apache/arrow-java · GitHub

/ arrow-java Public

GH-588: [Release] Increase wait interval in dev/release/release_rc.sh - #589

Merged
kou merged 1 commit into
apache:mainfrom
kou:release-increase-interval
Feb 6, 2025
ConversationCommits (1)ChecksFiles changed
Merged

GH-588: [Release] Increase wait interval in dev/release/release_rc.sh#589
kou merged 1 commit into
apache:mainfrom
kou:release-increase-interval

Conversation

kou commented Feb 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes GH-588.

release.yml takes at least 30min now. So 60s wait interval is too short. We can use longer interval to avoid needless API requests.

lidavidm approved these changes Feb 5, 2025
View reviewed changes
Comment thread dev/release/release_rc.sh
break
fi
sleep 60
sleep 600

lidavidm Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We have to wait 10 minutes!?

jbonofre Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As it's a sleep, it seems so. It's maybe related to @kou network. 10mn is OK though is necessary.

lidavidm Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah the issue explains the whole process takes ~30 minutes so ~10 minutes seems reasonable (I guess Github doesn't like pinging too often)

jbonofre Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, it's pretty clear regarding #588 (comment)

kou Feb 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes.
I've added it to this PR description too. Sorry. I should have explained it in the PR description too.

kou merged commit b933d2e into apache:main Feb 6, 2025
kou deleted the release-increase-interval branch February 6, 2025 00:55
lidavidm added this to the 18.3.0 milestone Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jbonofre jbonofre approved these changes
lidavidm lidavidm approved these changes
laurentgo Awaiting requested review from laurentgo laurentgo is a code owner
wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.3.0

Development

Successfully merging this pull request may close these issues.

[Release] Increase wait interval in dev/release/release_rc.sh

3 participants

Back | FazBrowse Home | New Git URL