MINOR: Add check-shebang-scripts-are-executable - #670
Merged
kou merged 1 commit intoMar 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lidavidm
marked this pull request as ready for review
March 10, 2025 07:23
This comment has been minimized.
jbonofre
approved these changes
Mar 10, 2025
kou
approved these changes
Mar 10, 2025
kou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
+1
Wow! I didn't know https://github.com/pre-commit/pre-commit-hooks has this built-in check too!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
BTW, this may help you: (add-hook 'after-save-hook 'executable-make-buffer-file-executable-if-script-p) |
Sorry, something went wrong.
timhurskidremio
pushed a commit
to timhurskidremio/dremio-arrow-java
that referenced
this pull request
Dec 5, 2025
## What's Changed Make sure that new scripts committed are actually executable, because I always forget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Make sure that new scripts committed are actually executable, because I always forget.