GH-692: Preserve nullability information while transfering DecimalVector and Decimal256Vector - #693
Merged
jbonofre merged 2 commits intoApr 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bodduv
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
March 27, 2025 12:00
This comment has been minimized.
Copy link
Copy Markdown
Contributor
Author
|
@lidavidm Thank you! Looks like the Dev PR Github workflow could not update milestone for the linked issue. |
Sorry, something went wrong.
jbonofre
reviewed
Mar 31, 2025
Comment thread
vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java
Outdated
jbonofre
reviewed
Mar 31, 2025
Comment thread
vector/src/main/java/org/apache/arrow/vector/DecimalVector.java
Outdated
jbonofre
approved these changes
Apr 3, 2025
jbonofre
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
lidavidm
approved these changes
Apr 3, 2025
bodduv
added a commit
to dremio/arrow-java
that referenced
this pull request
Apr 4, 2025
…malVector and Decimal256Vector (apache#693) ## What's Changed This PR proposes to use the "from" `ValueVector`'s field while transferring `DecimalVector` and `Decimal256Vector` to preserve nullability information. This is to have similar behavior with all the other primitive value vectors. Note that the `FieldType` of the value vector has nullability information. Closes apache#692 . (cherry picked from commit c29fcfc)
bodduv
added a commit
to dremio/arrow-java
that referenced
this pull request
Apr 4, 2025
…malVector and Decimal256Vector (apache#693) (#3) This PR proposes to use the "from" ValueVector's field while transferring DecimalVector and Decimal256Vector to preserve nullability information. This is to have similar behavior with all the other primitive value vectors. Note that the FieldType of the value vector has nullability information. Closes apache#692 . (cherry picked from commit c29fcfc)
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
May 15, 2025
### What changes were proposed in this pull request? This pr aims to upgrade `arrow-java` from 18.2.0 to 18.3.0. ### Why are the changes needed? The new version bring some bug fixes, like: - apache/arrow-java#627 - apache/arrow-java#654 - apache/arrow-java#656 - apache/arrow-java#693 - apache/arrow-java#705 - apache/arrow-java#707 - apache/arrow-java#722 In addition, the new version introduces a cascading upgrade for flatbuffers-java([ from 24.3.25 to 25.1.24 ](apache/arrow-java#600)) the full release note as follows: - https://github.com/apache/arrow-java/releases/tag/v18.3.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Acitons ### Was this patch authored or co-authored using generative AI tooling? No Closes #50892 from LuciferYang/arrow-java-18.3.0. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
timhurskidremio
pushed a commit
to timhurskidremio/dremio-arrow-java
that referenced
this pull request
Dec 5, 2025
…malVector and Decimal256Vector (apache#693) ## What's Changed This PR proposes to use the "from" `ValueVector`'s field while transferring `DecimalVector` and `Decimal256Vector` to preserve nullability information. This is to have similar behavior with all the other primitive value vectors. Note that the `FieldType` of the value vector has nullability information. Closes apache#692 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
This PR proposes to use the "from" ValueVector's field while transferring DecimalVector and Decimal256Vector to preserve nullability information. This is to have similar behavior with all the other primitive value vectors. Note that the FieldType of the value vector has nullability information.
Closes #692 .