GH-816: Presize JsonStringArrayList vector results - #817
Merged
lidavidm merged 3 commits intoAug 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
schlosna
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
August 11, 2025 17:36
lidavidm
approved these changes
Aug 12, 2025
Copy link
Copy Markdown
Member
|
Looks like the formatter isn't happy: Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.4:check (spotless-check) on project arrow-vector: The following files had format violations:
Error: src/main/java/org/apache/arrow/vector/complex/LargeListVector.java
Error: @@ -865,7 +865,8 @@
Error: ····final·long·start·=·offsetBuffer.getLong((long)·index·*·OFFSET_WIDTH);
Error: ····final·long·end·=·offsetBuffer.getLong(((long)·index·+·1L)·*·OFFSET_WIDTH);
Error: ····final·ValueVector·vv·=·getDataVector();
Error: -····final·List<Object>·vals·=·new·JsonStringArrayList<>(LargeMemoryUtil.checkedCastToInt(end·-·start));
Error: +····final·List<Object>·vals·=
Error: +········new·JsonStringArrayList<>(LargeMemoryUtil.checkedCastToInt(end·-·start));
Error: ····for·(long·i·=·start;·i·<·end;·i++)·{
Error: ······vals.add(vv.getObject(checkedCastToInt(i)));
Error: ····}
Error: Run 'mvn spotless:apply' to fix these violations.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There's more formatting errors than just that. Can you mvn spotless:apply? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Thanks for the quick review. Apologies about the format issue, I had tried to fix up while mobile. I've run mvn spotless:apply & pushed. |
Sorry, something went wrong.
lidavidm
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Presize JsonStringArrayLists when constructing them as part of ValueVector#getObject conversions.
FixedSizeListVector#getObject already performs this optimization; however, ListVector, ListViewVector, LargeListVector, and LargeListViewVector do not yet presize the result JsonStringArrayList requiring dynamic reallocations as elements are converted & added. This can become a scalability bottleneck when using these types.
Closes #816.