FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix PostCommit Java Hadoop Versions job by Amar3tto · Pull Request #36282 · apache/beam · GitHub

/ beam Public

Fix PostCommit Java Hadoop Versions job - #36282

Merged
damccorm merged 2 commits into
masterfrom
fix-hadoop
Sep 25, 2025
Merged

Fix PostCommit Java Hadoop Versions job#36282
damccorm merged 2 commits into
masterfrom
fix-hadoop

Conversation

Copy link
Copy Markdown
Collaborator

Fixes #33252
Succesful run: https://github.com/apache/beam/actions/runs/17998495081/job/51202484412

Old hadoop versions were deprecated for Iceberg.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)




See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue with the PostCommit Java Hadoop Versions job by updating the build.gradle configuration for the Iceberg IO connector. Specifically, it removes references to deprecated Hadoop versions (2.10.2 and 3.2.4) that are no longer supported for Iceberg, thereby ensuring the build process is stable and uses compatible dependencies.

Highlights

  • Deprecated Hadoop Versions: Removed Hadoop versions 2.10.2 and 3.2.4 from the hadoopVersions map in sdks/java/io/iceberg/build.gradle as they are deprecated for Iceberg.
  • Build Fix: This change addresses an issue with the PostCommit Java Hadoop Versions job, ensuring it runs successfully by removing unsupported configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Copy Markdown
Contributor

Old hadoop versions were deprecated for Iceberg.

Could you update https://github.com/apache/beam/blob/master/CHANGES.md as well? Do you have a reference to this from the iceberg side?

Amar3tto commented Sep 25, 2025
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Old hadoop versions were deprecated for Iceberg.

Could you update https://github.com/apache/beam/blob/master/CHANGES.md as well? Do you have a reference to this from the iceberg side?

Updated CHANGES.md, added a link to the Iceberg issue there

Copy link
Copy Markdown
Contributor

Thanks!

damccorm merged commit 432479c into master Sep 25, 2025
18 of 19 checks passed

Abacn commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

This breaks beam_PreCommit_Whitespace check (for changes.md)

Comment thread CHANGES.md
* X behavior was changed ([#X](https://github.com/apache/beam/issues/X)).
* (Python) Fixed transform naming conflict when executing DataTransform on a dictionary of PColls ([#30445](https://github.com/apache/beam/issues/30445)).
This may break update compatibility if you don't provide a `--transform_name_mapping`.
* Removed deprecated Hadoop versions (2.10.2 and 3.2.4) that are no longer supported for Iceberg ([Iceberg](https://github.com/apache/iceberg/issues/10940)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We may want to note that we only removed support of old Hadoop for Iceberg connector. Other component still does and have tests exercised, e.g.

Copy link
Copy Markdown
Contributor

Thanks! #36286

Amar3tto deleted the fix-hadoop branch October 9, 2025 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java Hadoop Versions job is flaky

3 participants


Back | FazBrowse Home | New Git URL