Release the RTMP peer key after key agreement - #3501
Merged
chenBright merged 1 commit intoAug 29, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Free the temporary peer public key after DH_compute_key returns so both successful and failed key agreement paths release it.
chenBright
approved these changes
Aug 29, 2026
chenBright
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
DHWrapper::copy_shared_key only released the temporary peer public key
when DH_compute_key failed. Successful RTMP complex handshakes retained the
allocation.
What is changed and the side effects?
Changed:
Release the temporary peer public key immediately after DH_compute_key
returns, covering both success and failure paths.
Side effects:
Performance effects: Negligible; this only releases an allocation when its
last use completes.
Breaking backward compatibility: No.
Check List: