CASSPYTHON-29 Allow user to specify arbitrary parameters for STARTUP message - #1305
Open
worryg0d wants to merge 1 commit into
Open
worryg0d wants to merge 1 commit into
worryg0d wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Patch enables users to specify arbitrary parametrs for STARTUP messages. This is useful for observability since Cassandra 4.1 STARTUP options are exposed in system_views.clients virtual table. Patch by Bohdan Siryk; reviewed by TBD for CASSPYTHON-29
swsekar
reviewed
Sep 14, 2026
swsekar
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Just left 1 nitpick, otherwise it looked generally good to me.
I'll leave it to @absurdfarce to give approval though.
Sorry, something went wrong.
Comment thread
cassandra/protocol.py
| )) | ||
|
|
||
| def __init__(self, cqlversion, options): | ||
| def __init__(self, cqlversion, options, extra_options=None): |
Copy link
Copy Markdown
There was a problem hiding this comment.
Nitpick: not sure if there is much use for distinguishing between options and extra_options in the StartupMessage class. Maybe they can be merged prior.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch enables users to specify arbitrary parametrs for STARTUP messages. This is useful for observability since Cassandra 4.1 STARTUP options are exposed in system_views.clients virtual table.
Patch by Bohdan Siryk; reviewed by TBD for CASSPYTHON-29