Ideally the tab should be always show, but when users try to edit settings and if VM is not stopped it should show an error like it does for reset password button etc
@rhtyd this control should be done in the server side, right? It is not just a UI problem, because if the USER uses the configurations API parameter, it seems that right now he/she would be able to change/override the overprovisioning configurations for his/her VMs.
@rafaelweingartner The backend need to honour the display field of a detail and perhaps we can add a global setting to say which details (by key/name) are blacklisted. @anuragaw deploy a latest 4.11 based env, deploy a VM and then stop it, you should see a setting tab in the VM details view.
@rhtyd that works. I also thought about adding a new parameter to that enum you created to indicate if the configuration can be changed/customized/overridden by the final user.
With #3244 the settings tab editing is not allowed when VM is running in the UI. However I don't think we should restrict users to not change the values, as it is allowed via API anyway.
With #3240 feature, users will know possible options they can pass. Wrt KVM, the number of allowed options/details are minimal.
Activity
yadvr commented on Nov 28, 2018
/cc @PaulAngus
yadvr commented on Dec 6, 2018
Ideally the tab should be always show, but when users try to edit settings and if VM is not stopped it should show an error like it does for reset password button etc
anuragaw commented on Dec 19, 2018
@ustcweizhou can you also please include some snapshot of the UI?
rafaelweingartner commented on Dec 19, 2018
@rhtyd this control should be done in the server side, right? It is not just a UI problem, because if the USER uses the configurations API parameter, it seems that right now he/she would be able to change/override the overprovisioning configurations for his/her VMs.
yadvr commented on Dec 19, 2018
@rafaelweingartner The backend need to honour the display field of a detail and perhaps we can add a global setting to say which details (by key/name) are blacklisted.
@anuragaw deploy a latest 4.11 based env, deploy a VM and then stop it, you should see a setting tab in the VM details view.
rafaelweingartner commented on Dec 19, 2018
@rhtyd that works. I also thought about adding a new parameter to that enum you created to indicate if the configuration can be changed/customized/overridden by the final user.
yadvr commented on Jun 25, 2019
With #3244 the settings tab editing is not allowed when VM is running in the UI. However I don't think we should restrict users to not change the values, as it is allowed via API anyway.
With #3240 feature, users will know possible options they can pass. Wrt KVM, the number of allowed options/details are minimal.