api: instance and template details are free text by yadvr · Pull Request #3240 · apache/cloudstack · GitHub

Problem: Users don't know what keys/values to enter for template and VM details.
Root Cause: The feature does not exist that can list possible details and options.
Solution: Based on the possible VM and template details handled by the
codebase, those details were refactored and a list API is introduced
that can return users those details along with possible values. When
users add details now, they will be presented with a list of key details
and their possible options if any.

Introduces a new API:

listDetailOptions: Lists all possible details and their options for a resource type such as a VM or a template
Required params: resourcetype, 
API Params               Type     Description
==========               ====     ===========
resourceid               string   the UUID of the resource (optional)
resourcetype             string   the resource type such as UserVm, Template etc.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rhtyd there's some build failures with this one, can you have a look?

[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vcs ---
[INFO] Deleting /jenkins/workspace/acs-pr-centos6-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.13.0.0-SNAPSHOT/plugins/network-elements/brocade-vcs (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:3.0.0:check (cloudstack-checkstyle) @ cloud-plugin-network-vcs ---
/opt/rh/maven30/root/usr/bin/mvn: line 9:  2041 Killed                  $M2_HOME/bin/mvn "$@"
error: Bad exit status from /var/tmp/rpm-tmp.ozlF7H (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.ozlF7H (%build)
+ '[' 1 -ne 0 ']'
+ '[' false == true ']'
+ echo 'RPM Build Failed '
RPM Build Failed 
+ exit 3
Build step 'Execute shell' marked build as failure
Stopping all containers
Finished: FAILURE

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-2653

@borisstoyanov looks like an env issue, let's try again
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2657

@blueorangutan test

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rhtyd got some comments for you here, I get this when logged as user:

Perhaps we could think about lining this up with #3213 and to be able properly to filter through the available options. Also user would be able to change/add settings to his VMs so this api should be available.

Trillian test result (tid-3458)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37191 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3240-t3458-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_privategw_static_routes	Failure	966.29	test_privategw_acl.py

Thanks for reporting the issue @borisstoyanov - the issue was missing role permission/authorization for the new API. I've fixed it.
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2676

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

LGTM @rhtyd, I wonder how's that going to work with #3244 and #3213, ie is a 'user' going to be able to see all the settings or just the ones he's being eligible to?

Trillian test result (tid-3469)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33155 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3240-t3469-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	Failure	413.21	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	440.47	test_vpc_redundant.py

With #3213, users won't be able to see the details admin decides to block. However, it's a presentation limitation only. With this FR, the user is only allowed a set of details that I thought can be allowed in most/all cases. (we can discuss/add/remove the details we want to export or not)

WIth #3244, users will alway see the tab and that some details may always be shown to the user but not allowed to edit. This again is a presentation limitation, a smart use can still use the API/cmk.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2813

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Last change is UI only change to show all possible drop down options while editing an existing detail. No smoketests needed.

@blueorangutan package

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2914

…ce-settings

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Fixed few minor issues cc @borisstoyanov @andrijapanic - Kindly kick packaging and build new Trillian env to review. Thanks.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-14

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-16)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30315 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3240-t16-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Lgtm received from @andrijapanic - can you confirm on the PR. I'll merge this based on testing and review.

LGTM

yadvr added the status:work-in-progress label Mar 28, 2019

yadvr added this to the 4.13.0.0 milestone Mar 28, 2019

yadvr requested review from PaulAngus, borisstoyanov and nvazquez March 28, 2019 09:36

borisstoyanov requested changes Apr 2, 2019

View reviewed changes

borisstoyanov approved these changes Apr 4, 2019

View reviewed changes

shwstppr force-pushed the vm-templates-instance-settings branch from ef16447 to eb5c5b0 Compare May 30, 2019 08:31

during editing, show all detail options if available

81346bf

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Merge remote-tracking branch 'origin/master' into vm-templates-instan…

e1f00e2

…ce-settings

yadvr added 3 commits June 24, 2019 13:12

return rootdisksize detail

2e368c7

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

add osdefault to KVM root disk controller

5d64537

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

remove redundant string

aa5acbc

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

call the listdetails API before rendering the list view table rows

63c6f31

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr mentioned this pull request Jun 25, 2019

User can see the setting tab of vms, and change the value of settings #3043

Closed

yadvr changed the title [WIP DO NOT MERGE] api: instance and template details are free text api: instance and template details are free text Jun 27, 2019

yadvr removed the status:work-in-progress label Jun 27, 2019

yadvr merged commit 9f4f2c5 into apache:master Jun 27, 2019

api: instance and template details are free text by yadvr · Pull Request #3240 · apache/cloudstack · GitHub

Repository navigation

api: instance and template details are free text - #3240

api: instance and template details are free text#3240yadvr merged 12 commits intoapache:masterapache/cloudstack:masterfrom shapeblue:vm-templates-instance-settingsshapeblue/cloudstack:vm-templates-instance-settingsCopy head branch name to clipboard

Conversation

yadvr commented Mar 28, 2019

Types of changes

Screenshots (if appropriate):

Uh oh!

borisstoyanov commented Mar 28, 2019

Uh oh!

blueorangutan commented Mar 28, 2019

Uh oh!

borisstoyanov commented Mar 28, 2019

Uh oh!

blueorangutan commented Mar 28, 2019

Uh oh!

yadvr commented Mar 28, 2019

Uh oh!

blueorangutan commented Mar 28, 2019

Uh oh!

blueorangutan commented Mar 28, 2019

Uh oh!

borisstoyanov commented Apr 2, 2019

Uh oh!

blueorangutan commented Apr 2, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 2, 2019

Uh oh!

yadvr commented Apr 4, 2019

Uh oh!

blueorangutan commented Apr 4, 2019

Uh oh!

blueorangutan commented Apr 4, 2019

Uh oh!

yadvr commented Apr 4, 2019

Uh oh!

blueorangutan commented Apr 4, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 4, 2019

Uh oh!

yadvr commented Apr 5, 2019

Uh oh!

yadvr commented May 30, 2019

Uh oh!

blueorangutan commented May 30, 2019

Uh oh!

blueorangutan commented May 30, 2019

Uh oh!

yadvr commented May 30, 2019

Uh oh!

blueorangutan commented May 30, 2019

Uh oh!

yadvr commented Jun 20, 2019

Uh oh!

PaulAngus commented Jun 20, 2019

Uh oh!

blueorangutan commented Jun 20, 2019

Uh oh!

blueorangutan commented Jun 20, 2019

Uh oh!

yadvr commented Jun 24, 2019

Uh oh!

blueorangutan commented Jun 24, 2019

Uh oh!

yadvr commented Jun 24, 2019

Uh oh!

yadvr commented Jun 24, 2019

Uh oh!

blueorangutan commented Jun 24, 2019

Uh oh!

blueorangutan commented Jun 24, 2019

Uh oh!

borisstoyanov commented Jun 24, 2019

api: instance and template details are free text#3240
yadvr merged 12 commits into
apache:masterfrom
shapeblue:vm-templates-instance-settings