FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixup alerting and logging error in BGPServiceImpl by vishesh92 · Pull Request #10252 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Fixup alerting and logging error in BGPServiceImpl - #10252

Merged
Pearl1594 merged 3 commits into
apache:4.20from
shapeblue:fixup-logging-and-alerting
Feb 18, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Fixup alerting and logging error in BGPServiceImpl#10252
Pearl1594 merged 3 commits into
apache:4.20from
shapeblue:fixup-logging-and-alerting

Conversation

vishesh92 commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes:

  • NPE when dcId is null or 0L on sending an alert.
  • Exception during logging in BGPServiceImpl
Generated summary

This pull request includes several changes to the AlertManagerImpl and BGPServiceImpl classes to improve code clarity and functionality. The most important changes involve the handling of data center IDs and the logging of AS number allocations.

Improvements to AlertManagerImpl:

Improvements to BGPServiceImpl:

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 commented Jan 23, 2025

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Jan 23, 2025

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.99%. Comparing base (96b757c) to head (f3e28fe).
Report is 74 commits behind head on 4.20.

Files with missing lines Patch % Lines
...er/src/main/java/com/cloud/bgp/BGPServiceImpl.java 0.00% 3 Missing ⚠️
...rc/main/java/com/cloud/alert/AlertManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10252      +/-   ##
============================================
- Coverage     16.13%   15.99%   -0.15%     
- Complexity    12972    13080     +108     
============================================
  Files          5639     5649      +10     
  Lines        494297   495623    +1326     
  Branches      59908    60003      +95     
============================================
- Hits          79773    79255     -518     
- Misses       405698   407519    +1821     
- Partials       8826     8849      +23
Flag Coverage Δ
uitests 4.01% <ø> (-0.02%) ⬇️
unittests 16.82% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92 force-pushed the fixup-logging-and-alerting branch from 51f7677 to 9194370 Compare January 23, 2025 10:40

weizhouapache commented Jan 23, 2025

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Jan 23, 2025

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Jan 23, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12187

blueorangutan commented Jan 23, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12188

vishesh92 commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

@blueorangutan test

apache deleted a comment from blueorangutan Jan 24, 2025
apache deleted a comment from blueorangutan Jan 24, 2025

blueorangutan commented Jan 24, 2025

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Jan 24, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-12180)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48495 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10252-t12180-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

weizhouapache mentioned this pull request Feb 3, 2025
Merged
2 of 14 tasks
weizhouapache reviewed Feb 3, 2025
View reviewed changes

weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code lgtm

hsato03 mentioned this pull request Feb 3, 2025
Merged
2 of 13 tasks

weizhouapache commented Feb 4, 2025

Copy link
Copy Markdown
Member

@DaanHoogland
can you review this ?

DaanHoogland reviewed Feb 4, 2025
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code looks good, are there any tests, unit or integration, that cover this bit, @vishesh92 ?

weizhouapache mentioned this pull request Feb 9, 2025
Merged
2 of 14 tasks

vishesh92 commented Feb 13, 2025

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Feb 13, 2025

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Feb 13, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12442

vishesh92 commented Feb 13, 2025

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Feb 13, 2025

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Feb 13, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12447

DaanHoogland added this to the 4.20.1 milestone Feb 13, 2025
DaanHoogland reviewed Feb 13, 2025
View reviewed changes
Comment thread server/src/main/java/com/cloud/bgp/BGPServiceImpl.java Resolved
Comment thread server/src/test/java/com/cloud/alert/AlertManagerImplTest.java Resolved
Comment thread server/src/test/java/com/cloud/alert/AlertManagerImplTest.java Resolved
Comment thread server/src/test/java/com/cloud/alert/AlertManagerImplTest.java Resolved
Apply suggestions from code review
f3e28fe 
Co-authored-by: dahn <daan.hoogland@gmail.com>

vishesh92 commented Feb 13, 2025

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Feb 13, 2025

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Feb 13, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12450

Pearl1594 commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Feb 14, 2025

Copy link
Copy Markdown

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

weizhouapache approved these changes Feb 14, 2025
View reviewed changes

weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code lgtm

smoke test results look good

blueorangutan commented Feb 15, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-12411)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58696 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10252-t12411-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_06_purge_expunged_vm_background_task Failure 388.39 test_purge_expunged_vms.py

Pearl1594 approved these changes Feb 18, 2025
View reviewed changes

Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code LGTM

Pearl1594 merged commit 6a3314c into apache:4.20 Feb 18, 2025
Pearl1594 deleted the fixup-logging-and-alerting branch February 18, 2025 14:23
Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Fixup alerting and logging error in BGPServiceImpl (apache#10252)
d14a0dd 
* Fixup alerting and logging error in BGPServiceImpl

* Update unit tests

* Apply suggestions from code review

Co-authored-by: dahn <daan.hoogland@gmail.com>

---------

Co-authored-by: dahn <daan.hoogland@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland left review comments
Pearl1594 Pearl1594 approved these changes
weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL