FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Move templates creation date to the Zones tab by nvazquez · Pull Request #10709 · apache/cloudstack · GitHub

/ cloudstack Public

UI: Move templates creation date to the Zones tab - #10709

Merged
weizhouapache merged 2 commits into
apache:4.19from
shapeblue:419-templatezones-ui
Apr 17, 2025
ConversationCommits (2)ChecksFiles changed
Merged

UI: Move templates creation date to the Zones tab#10709
weizhouapache merged 2 commits into
apache:4.19from
shapeblue:419-templatezones-ui

Conversation

nvazquez commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Description

This PR moves the creation date of a template to the Zones tab on the template view and removes the zone field on the left side menu. This behavior is changed to support templates on multiple zones, which should display the different creation dates for each zone. These are correctly displayed on the Template view -> Zones tab.

Fixes: #10599

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Apr 14, 2025

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov Bot commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (f13cf59) to head (d452375).
Report is 2 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10709   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
- Complexity    11332    11333    +1     
=========================================
  Files          5415     5415           
  Lines        474893   474893           
  Branches      57920    57920           
=========================================
+ Hits          72046    72048    +2     
+ Misses       394792   394791    -1     
+ Partials       8055     8054    -1
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan commented Apr 14, 2025

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10709 (QA-JID-596)

nvazquez mentioned this pull request Apr 14, 2025
Closed
nvazquez added this to the 4.19.3 milestone Apr 14, 2025
kiranchavala reviewed Apr 15, 2025
View reviewed changes

kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@nvazquez Could you please add the same behaviour of ISO and kubernets iso section also

kiranchavala self-assigned this Apr 15, 2025

DaanHoogland commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

I agree with @kiranchavala on ISOs. I’m not so sure about k8s ISOs. Can you have a look @nvazquez ?

nvazquez commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

@kiranchavala @DaanHoogland I have applied the changes for ISOs, however the Kubernetes ISOs view doesn't have the Zones section per se, have to then select the created ISO to view it

@blueorangutan ui

blueorangutan commented Apr 15, 2025

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Apr 15, 2025

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10709 (QA-JID-598)

DaanHoogland approved these changes Apr 15, 2025
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ltgm (tested in qa)

nvazquez linked an issue Apr 15, 2025 that may be closed by this pull request
UI : Creation date of Template is changed when its copied #10599
Closed
kiranchavala approved these changes Apr 17, 2025
View reviewed changes

kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM Tested in the qa server

weizhouapache approved these changes Apr 17, 2025
View reviewed changes

weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code lgtm

weizhouapache merged commit 8db248e into apache:4.19 Apr 17, 2025
DaanHoogland deleted the 419-templatezones-ui branch April 17, 2025 07:59
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
UI: Move templates creation date to the Zones tab (apache#10709)
a554edf 
* UI: Move templates creation date to the Zones tab

* Extend changes to ISOs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kiranchavala kiranchavala approved these changes
DaanHoogland DaanHoogland approved these changes
weizhouapache weizhouapache approved these changes
harikrishna-patnala Awaiting requested review from harikrishna-patnala
Pearl1594 Awaiting requested review from Pearl1594
sureshanaparti Awaiting requested review from sureshanaparti
borisstoyanov Awaiting requested review from borisstoyanov

Assignees

kiranchavala

Labels

component:templates component:UI needs-review

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

UI : Creation date of Template is changed when its copied

5 participants

Back | FazBrowse Home | New Git URL