FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix importing unmanaged instances due to incorrect internal name by nvazquez · Pull Request #11753 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Fix importing unmanaged instances due to incorrect internal name - #11753

Merged
weizhouapache merged 1 commit into
apache:4.20from
shapeblue:420-fix-import-unmanaged-kvm
Sep 30, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Fix importing unmanaged instances due to incorrect internal name#11753
weizhouapache merged 1 commit into
apache:4.20from
shapeblue:420-fix-import-unmanaged-kvm

Conversation

nvazquez commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes the import of unmanaged instances, the error was a regression from PR #11659

Fixes: #11737

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested on KVM environment - importing unmanaged instances worked properly

How did you try to break this feature and the system with this change?

nvazquez added this to the 4.20.2 milestone Sep 29, 2025
nvazquez mentioned this pull request Sep 29, 2025
Closed

codecov Bot commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (5dfeb79) to head (80d9d13).
⚠️ Report is 1 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #11753      +/-   ##
============================================
- Coverage     16.17%   16.17%   -0.01%     
+ Complexity    13296    13294       -2     
============================================
  Files          5656     5656              
  Lines        498223   498223              
  Branches      60454    60454              
============================================
- Hits          80577    80576       -1     
+ Misses       408676   408675       -1     
- Partials       8970     8972       +2
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nvazquez commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Sep 29, 2025

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache approved these changes Sep 29, 2025
View reviewed changes

weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

make sense

weizhouapache commented Sep 29, 2025

Copy link
Copy Markdown
Member

@sudo87
can you review it ?

sudo87 approved these changes Sep 29, 2025
View reviewed changes

sudo87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

sudo87 added a commit to shapeblue/cloudstack that referenced this pull request Sep 29, 2025
include import unmanaged instance fix from apache#11753
4e36aa1

blueorangutan commented Sep 29, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15220

nvazquez commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Sep 29, 2025

Copy link
Copy Markdown

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

weizhouapache commented Sep 29, 2025

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Sep 29, 2025

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

weizhouapache commented Sep 29, 2025

Copy link
Copy Markdown
Member

tested vm unmanage/import several times, all worked

shwstppr approved these changes Sep 30, 2025
View reviewed changes

shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code lgtm

rajujith approved these changes Sep 30, 2025
View reviewed changes

rajujith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tested
LGTM

blueorangutan commented Sep 30, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-14475)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55923 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11753-t14475-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

weizhouapache commented Sep 30, 2025

Copy link
Copy Markdown
Member

merging based on approvals and manual test

weizhouapache merged commit 30cb8c7 into apache:4.20 Sep 30, 2025
DaanHoogland deleted the 420-fix-import-unmanaged-kvm branch September 30, 2025 07:07

blueorangutan commented Sep 30, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-14476)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56259 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11753-t14476-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
Fix importing unmanaged instances due to incorrect internal name (apa…
7072045 
…che#11753)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shwstppr shwstppr approved these changes
sudo87 sudo87 approved these changes
rajujith rajujith approved these changes
weizhouapache weizhouapache approved these changes
DaanHoogland Awaiting requested review from DaanHoogland
RosiKyu Awaiting requested review from RosiKyu

Assignees

No one assigned

Labels

component:import type:bug

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL