FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change internal ID to UUID in user disable event by erikbocks · Pull Request #11824 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Change internal ID to UUID in user disable event - #11824

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:change-user-disable-event-message
Jan 9, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Change internal ID to UUID in user disable event#11824
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:change-user-disable-event-message

Conversation

erikbocks commented Oct 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

During the user disablement process, created events contain the user internal ID instead of the user UUID. Therefore, this PR fixes this behaviour by changing the internal ID in the event descriptions to the user's UUID.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I built the packages with the changes and applied them to my local environment. In Apache CloudStack, I created a new user user in the admin account, then disabled it. In the events, I validated that the user's UUID were shown instead of the user's internal ID.

How did you try to break this feature and the system with this change?

codecov Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (ec533cd) to head (b775848).
⚠️ Report is 249 commits behind head on main.

Files with missing lines Patch % Lines
...udstack/api/command/admin/user/DisableUserCmd.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11824      +/-   ##
============================================
+ Coverage     17.42%   17.56%   +0.13%     
- Complexity    15336    15498     +162     
============================================
  Files          5892     5899       +7     
  Lines        526521   527793    +1272     
  Branches      64293    64479     +186     
============================================
+ Hits          91767    92703     +936     
- Misses       424401   424666     +265     
- Partials      10353    10424      +71
Flag Coverage Δ
uitests 3.59% <ø> (-0.02%) ⬇️
unittests 18.62% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland approved these changes Oct 13, 2025
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

vishesh92 approved these changes Oct 13, 2025
View reviewed changes

vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm. didn't test.

DaanHoogland commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Oct 13, 2025

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Oct 13, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15432

DaanHoogland commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Oct 16, 2025

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Oct 17, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-14701)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51596 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11824-t14701-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

DaanHoogland mentioned this pull request Oct 17, 2025
Closed
daviftorres mentioned this pull request Nov 6, 2025
Merged
1 of 14 tasks
bernardodemarco approved these changes Jan 8, 2026
View reviewed changes

bernardodemarco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, I manually tested it in a local environment:

bernardodemarco added this to the 4.23.0 milestone Jan 8, 2026
DaanHoogland merged commit 1ef6365 into apache:main Jan 9, 2026
1 of 2 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 21, 2026
Change internal ID to UUID in user disable event (apache#11824)
e45947a
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
Change internal ID to UUID in user disable event (apache#11824)
ef1c269
owsferraro pushed a commit to owsferraro/cloudstack that referenced this pull request Mar 25, 2026
Change internal ID to UUID in user disable event (apache#11824)
e9fdd44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
weizhouapache weizhouapache left review comments
vishesh92 vishesh92 approved these changes
bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL