FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

extension: import using yaml manifest by shwstppr · Pull Request #12102 · apache/cloudstack · GitHub

/ cloudstack Public

extension: import using yaml manifest - #12102

Closed
shwstppr wants to merge 6 commits into
apache:mainfrom
shapeblue:feat-import-ext
ConversationCommits (6)ChecksFiles changed
Closed

extension: import using yaml manifest#12102
shwstppr wants to merge 6 commits into
apache:mainfrom
shapeblue:feat-import-ext

Conversation

shwstppr commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds import functionality for extension by giving an YAML manifest URL. Manifest will define extension and its custom actions details.

Based on CCC 2025 Hackathon idea by @msinhore and the contribution by @sudo87

Doc PR: apache/cloudstack-documentation#600

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

(localcloud) 🐱 > import extension manifesturl=https://raw.githubusercontent.com/msinhore/cloudstack-firecracker-extension/refs/heads/main/manifest.yml
{
  "extension": {
    "created": "2025-11-20T04:45:01+0530",
    "description": "External orchestrator extension that integrates Firecracker microVMs with Apache CloudStack via the Orchestrator Extension Framework.\n",
    "id": "214387be-fabc-4958-8ffa-b12df3c801b4",
    "isuserdefined": true,
    "name": "firecracker",
    "orchestratorrequirespreparevm": false,
    "path": "/home/shwstppr/lab/shapeblue/cloudstack/extensions/firecracker/firecracker.py",
    "pathready": true,
    "state": "Enabled",
    "type": "Orchestrator"
  }
}
(localcloud) 🐱 > list extensions id=214387be-fabc-4958-8ffa-b12df3c801b4 (firecracker)
{
  "count": 1,
  "extension": [
    {
      "created": "2025-11-20T04:45:01+0530",
      "description": "External orchestrator extension that integrates Firecracker microVMs with Apache CloudStack via the Orchestrator Extension Framework.\n",
      "id": "214387be-fabc-4958-8ffa-b12df3c801b4",
      "isuserdefined": true,
      "name": "firecracker",
      "orchestratorrequirespreparevm": false,
      "path": "/home/shwstppr/lab/shapeblue/cloudstack/extensions/firecracker/firecracker.py",
      "pathready": true,
      "state": "Enabled",
      "type": "Orchestrator"
    }
  ]
}
(localcloud) 🐱 > list customactions extensionid=214387be-fabc-4958-8ffa-b12df3c801b4 (firecracker)
{
  "count": 4,
  "extensioncustomaction": [
    {
      "allowedroletypes": [
        "Admin",
        "DomainAdmin",
        "User"
      ],
      "created": "2025-11-20T04:45:01+0530",
      "description": "Delete a snapshot for a virtual machine instance.",
      "details": {},
      "enabled": true,
      "extensionid": "214387be-fabc-4958-8ffa-b12df3c801b4",
      "extensionname": "firecracker",
      "id": "37233ea1-4a5f-47cf-bd15-3e0c9a9d1e7c",
      "name": "DeleteSnapshot",
      "parameters": [
        {
          "name": "snap_name",
          "required": true,
          "type": "STRING",
          "validationformat": "NONE"
        }
      ],
      "resourcetype": "VirtualMachine",
      "timeout": 300
    },
    {
      "allowedroletypes": [
        "Admin",
        "DomainAdmin",
        "User"
      ],
      "created": "2025-11-20T04:45:01+0530",
      "description": "Restore a virtual machine instance from a given snapshot.",
      "details": {},
      "enabled": true,
      "extensionid": "214387be-fabc-4958-8ffa-b12df3c801b4",
      "extensionname": "firecracker",
      "id": "4edf2208-dce5-4ecb-a030-61193adb9825",
      "name": "RestoreSnapshot",
      "parameters": [
        {
          "name": "snap_name",
          "required": true,
          "type": "STRING",
          "validationformat": "NONE"
        }
      ],
      "resourcetype": "VirtualMachine",
      "timeout": 900
    },
    {
      "allowedroletypes": [
        "Admin",
        "DomainAdmin",
        "User"
      ],
      "created": "2025-11-20T04:45:01+0530",
      "description": "List all snapshots for a virtual machine instance.",
      "details": {},
      "enabled": true,
      "extensionid": "214387be-fabc-4958-8ffa-b12df3c801b4",
      "extensionname": "firecracker",
      "id": "de999133-75a5-45da-8893-63622fe02a44",
      "name": "ListSnapshots",
      "parameters": [],
      "resourcetype": "VirtualMachine",
      "timeout": 120
    },
    {
      "allowedroletypes": [
        "Admin",
        "DomainAdmin",
        "User"
      ],
      "created": "2025-11-20T04:45:01+0530",
      "description": "Create a snapshot for a virtual machine instance.",
      "details": {},
      "enabled": true,
      "extensionid": "214387be-fabc-4958-8ffa-b12df3c801b4",
      "extensionname": "firecracker",
      "id": "80b3b994-1ac8-4193-a6b9-9c72146c8815",
      "name": "CreateSnapshot",
      "parameters": [
        {
          "name": "snap_name",
          "required": true,
          "type": "STRING",
          "validationformat": "NONE"
        },
        {
          "name": "snap_description",
          "required": false,
          "type": "STRING",
          "validationformat": "NONE"
        },
        {
          "name": "snap_save_memory",
          "required": false,
          "type": "BOOLEAN",
          "validationformat": "NONE"
        }
      ],
      "resourcetype": "VirtualMachine",
      "timeout": 600
    }
  ]
}

How did you try to break this feature and the system with this change?

feature: import extension using yaml manifest
400f292 
Adds import functionality for extension by giving an YAML manifest URL.
Manifest will define extension and its custom actions details.

Co-authored-by: Manoj Kumar <manojkr.itbhu@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache commented Nov 19, 2025

Copy link
Copy Markdown
Member

great job !

would it be possible to upload zipped files from local ?

codecov Bot commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.51934% with 133 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.95%. Comparing base (82bfa9f) to head (7144653).

Files with missing lines Patch % Lines
...xtensions/manager/ExtensionsImportManagerImpl.java 0.00% 55 Missing ⚠️
...dstack/framework/extensions/util/ZipExtractor.java 0.00% 31 Missing ⚠️
...ack/framework/extensions/util/ExtensionConfig.java 31.57% 25 Missing and 1 partial ⚠️
...k/framework/extensions/api/ImportExtensionCmd.java 0.00% 17 Missing ⚠️
...oudstack/framework/extensions/util/YamlParser.java 72.72% 2 Missing and 1 partial ⚠️
...work/extensions/manager/ExtensionsManagerImpl.java 96.55% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12102      +/-   ##
============================================
- Coverage     17.95%   17.95%   -0.01%     
- Complexity    16522    16529       +7     
============================================
  Files          6022     6028       +6     
  Lines        541387   541571     +184     
  Branches      66346    66365      +19     
============================================
+ Hits          97211    97236      +25     
- Misses       433210   433367     +157     
- Partials      10966    10968       +2
Flag Coverage Δ
uitests 3.52% <ø> (-0.01%) ⬇️
unittests 19.10% <26.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr changed the title feature: import extension using yaml manifest extension: import using yaml manifest Nov 19, 2025
fix
bc22804 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @weizhouapache. Currently, local upload is not supported. Also, for local upload, do you mean uploading the manifest YAML from local machine or the complete extension source?
Either way, it would first need implementation of allowing upload on the management server (Currently we only upload via SSVM) or we upload to SSVM (secondary store) and then transfer to the management server host
If it is just the YAML then we can follow the same flow - get YAML, parse it, download the extension source and automate the process of adding extension and its actions.
For extension source upload, the operator need to pass extension details like name, description, type, etc.

license
57a7ffd 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
more license
22a8e58 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Nov 20, 2025

Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Nov 20, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15798

blueorangutan commented Nov 26, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15834

shwstppr added a commit to shapeblue/cloudstack-documentation that referenced this pull request Nov 28, 2025
extension: import using manifest
61639b2 
For apache/cloudstack#12102

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr mentioned this pull request Nov 28, 2025
Draft

github-actions Bot commented Mar 29, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache added this to the 4.23.0 milestone May 7, 2026

shwstppr commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks @msinhore. If needed you or others can carry forward this. This was more of a PoC and may need some discussion on import structure
Your suggestion around details makes sense

shwstppr closed this May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland left review comments
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

component:api component:build component:UI

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL