FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ui: do not show deploy instance button for not ready images by shwstppr · Pull Request #13161 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

ui: do not show deploy instance button for not ready images - #13161

Merged
winterhazel merged 3 commits into
apache:4.22from
shapeblue:ui-depltmpl-notreadytmpl
Jun 11, 2026
ConversationCommits (3)ChecksFiles changed
Merged

ui: do not show deploy instance button for not ready images#13161
winterhazel merged 3 commits into
apache:4.22from
shapeblue:ui-depltmpl-notreadytmpl

Conversation

shwstppr commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

Currently, InfoCard for a not ready template shows deploy instance button which is incorrect.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

ui: do not show deploy instance button for not ready images
f16be94 
Currently, InfoCard for a not ready template shows deploy instance
button which is incorrect.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

codecov Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (a289bb0) to head (9a06a57).
⚠️ Report is 6 commits behind head on 4.22.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #13161      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
+ Complexity    15792    15784       -8     
============================================
  Files          5922     5922              
  Lines        533123   533123              
  Branches      65201    65203       +2     
============================================
- Hits          94246    94230      -16     
- Misses       428236   428248      +12     
- Partials      10641    10645       +4
Flag Coverage Δ
uitests 3.69% <ø> (-0.01%) ⬇️
unittests 18.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti commented May 14, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

winterhazel added this to the 4.22.2 milestone May 15, 2026

kiranchavala commented May 18, 2026

Copy link
Copy Markdown
Member

@blueorangutan ui

blueorangutan commented May 18, 2026

Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

sureshanaparti requested a review from Copilot May 18, 2026 17:08
Copilot AI reviewed May 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

DaanHoogland requested a review from Copilot May 20, 2026 10:08

DaanHoogland commented May 20, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented May 20, 2026

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copilot AI reviewed May 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Resolved
Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Resolved
Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Resolved

blueorangutan commented May 20, 2026

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13161 (QA-JID-928)

Apply suggestions from code review
9537afb 
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr requested a review from Copilot May 20, 2026 11:58
Copilot AI reviewed May 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Resolved
Potential fix for pull request finding
9a06a57 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

DaanHoogland commented May 21, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented May 21, 2026

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented May 21, 2026

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13161 (QA-JID-934)

DaanHoogland approved these changes May 22, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm, no testing yet

winterhazel approved these changes Jun 11, 2026
View reviewed changes

winterhazel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. I checked in a local environment that the deploy button is, in fact, not shown for templates/ISOs that are not ready anymore.

winterhazel merged commit 8e933b7 into apache:4.22 Jun 11, 2026
25 of 26 checks passed
This was referenced Jun 11, 2026
Closed
Closed
Closed
Closed
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 11, 2026
ui: do not show deploy instance button for not ready images (apache#1…
03e218d 
…3161)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
(cherry picked from commit 8e933b7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
DaanHoogland DaanHoogland approved these changes
winterhazel winterhazel approved these changes

Assignees

No one assigned

Labels

component:UI status:needs-testing

Projects

None yet

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL