FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Retry VM migration to next available host, and dont stop VM on migrate failure by sureshanaparti · Pull Request #13189 · apache/cloudstack · GitHub

/ cloudstack Public

Retry VM migration to next available host, and dont stop VM on migrate failure - #13189

Draft
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:vm-migrate-retry-and-dont-stop-on-fail
ConversationCommits (1)ChecksFiles changed
Draft

Retry VM migration to next available host, and dont stop VM on migrate failure#13189
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:vm-migrate-retry-and-dont-stop-on-fail

Conversation

sureshanaparti commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR enables retry (HA triggered) VM migration to next available host and doesn't stop VM on migrate failure.

Fixes #13010

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti linked an issue May 19, 2026 that may be closed by this pull request
Instance random get stopped while live migration triggered by host maintenance #13010
Open
sureshanaparti requested a review from Copilot May 19, 2026 10:02

sureshanaparti commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented May 19, 2026

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (a289bb0) to head (d93524d).
⚠️ Report is 4 commits behind head on 4.22.

Files with missing lines Patch % Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 9.09% 10 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #13189      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
+ Complexity    15792    15784       -8     
============================================
  Files          5922     5922              
  Lines        533123   533125       +2     
  Branches      65201    65202       +1     
============================================
- Hits          94246    94228      -18     
- Misses       428236   428251      +15     
- Partials      10641    10646       +5
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI reviewed May 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

sureshanaparti marked this pull request as ready for review May 19, 2026 10:47

blueorangutan commented May 19, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17908

vishesh92 approved these changes May 20, 2026
View reviewed changes

vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm. didn't test.

vishesh92 self-assigned this May 21, 2026
DaanHoogland approved these changes May 21, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

vishesh92 marked this pull request as draft May 22, 2026 08:52

vishesh92 commented Jun 1, 2026

Copy link
Copy Markdown
Member

In some scenarios depending on what point the request fails on the agent, the retry method can result in restart of the VM. I had to attached debugger to test this.

weizhouapache added this to the 4.22.2 milestone Jun 29, 2026
github-project-automation Bot moved this to Backlog in Testing Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
DaanHoogland DaanHoogland approved these changes
vishesh92 vishesh92 approved these changes
nvazquez Awaiting requested review from nvazquez

Assignees

vishesh92

Labels

component:compute component:orchestration needs-testing

Projects

Testing
Status: Backlog

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

Instance random get stopped while live migration triggered by host maintenance

7 participants

Back | FazBrowse Home | New Git URL