FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert command's timeout for incremental snapshots by erikbocks · Pull Request #13212 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Convert command's timeout for incremental snapshots - #13212

Merged
winterhazel merged 3 commits into
apache:4.22from
scclouds:fix-incremental-snapshot-timeout
Jul 10, 2026
ConversationCommits (3)ChecksFiles changed
Merged

Convert command's timeout for incremental snapshots #13212
winterhazel merged 3 commits into
apache:4.22from
scclouds:fix-incremental-snapshot-timeout

Conversation

erikbocks commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR handles the conversion of command's timeout for incremental snapshots, complementing the #13210 changes (reason: #13210 (comment)).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

erikbocks requested a review from winterhazel May 21, 2026 19:47
winterhazel approved these changes May 21, 2026
View reviewed changes

winterhazel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code looks good, but did not test.

winterhazel commented May 21, 2026

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented May 21, 2026

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (d1e1aa5) to head (2a7b5b2).
⚠️ Report is 67 commits behind head on 4.22.

Files with missing lines Patch % Lines
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 5 Missing ⚠️
...java/org/apache/cloudstack/utils/qemu/QemuImg.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #13212      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
- Complexity    15791    15792       +1     
============================================
  Files          5922     5922              
  Lines        533127   533166      +39     
  Branches      65205    65208       +3     
============================================
+ Hits          94243    94244       +1     
- Misses       428239   428276      +37     
- Partials      10645    10646       +1
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan commented May 21, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17971

DaanHoogland reviewed May 22, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm generally, just wondering if we could hit an overflow

Comment thread plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java Resolved

DaanHoogland commented May 22, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented May 22, 2026

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland mentioned this pull request May 22, 2026
Merged
2 of 12 tasks

blueorangutan commented May 23, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-16163)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55642 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13212-t16163-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

winterhazel added this to the 4.22.2 milestone Jun 1, 2026
JoaoJandre approved these changes Jun 15, 2026
View reviewed changes

JoaoJandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM

bernardodemarco approved these changes Jul 10, 2026
View reviewed changes

bernardodemarco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, tested locally.

Verified that the creation of volume incremental snapshots was not affected (no regressions were identified), and that the timeout is correctly converted to milliseconds:

winterhazel merged commit 8225668 into apache:4.22 Jul 10, 2026
25 of 26 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 11, 2026
Fix QEMU convert command timeout for incremental snapshots (apache#13212
cba428c 
)

(cherry picked from commit 8225668)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland left review comments
winterhazel winterhazel approved these changes
JoaoJandre JoaoJandre approved these changes
bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

component:kvm

Projects

None yet

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL