FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't allow assign VM to backup offering for VM with encrypted volumes by sureshanaparti · Pull Request #13229 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Don't allow assign VM to backup offering for VM with encrypted volumes - #13229

Open
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:dont-allow-assign-backup-offering-for-vm-with-encrypted-volumes
ConversationCommits (1)ChecksFiles changed
Open

Don't allow assign VM to backup offering for VM with encrypted volumes#13229
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:dont-allow-assign-backup-offering-for-vm-with-encrypted-volumes

Conversation

sureshanaparti commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR does't allow assign VM to backup offering for VM with encrypted volumes.

Fixes #13197

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Deploy VM with compute / disk offering with encrypted set to true.
  • Create a backup offering.
  • Assign backup offering to the VM above.

When tried to create backup without a backup offering assigned, it fails with "VM has not backup offering configured, cannot create backup"

How did you try to break this feature and the system with this change?

sureshanaparti linked an issue May 25, 2026 that may be closed by this pull request
Don't allow NAS backup for vm with encrypted volumes #13197
Open
sureshanaparti added this to the 4.22.2 milestone May 25, 2026

sureshanaparti commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented May 25, 2026

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (21b2025) to head (3e0894d).
⚠️ Report is 229 commits behind head on 4.22.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #13229      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
+ Complexity    15792    15790       -2     
============================================
  Files          5922     5922              
  Lines        533165   533170       +5     
  Branches      65208    65210       +2     
============================================
- Hits          94242    94223      -19     
- Misses       428276   428301      +25     
+ Partials      10647    10646       -1
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.74% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan commented May 25, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18012

DaanHoogland commented May 26, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented May 26, 2026

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented May 26, 2026

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-16177)

kiranchavala commented Jun 2, 2026

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Jun 2, 2026

Copy link
Copy Markdown

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Jun 2, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-16238)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50447 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13229-t16238-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

This comment was marked as outdated.

Sign in to view

This was referenced Jun 13, 2026
Closed
Closed
abh1sar requested changes Jun 24, 2026
View reviewed changes
Comment thread server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
Comment on lines +444 to +450
List<VolumeVO> volumes = volumeDao.findByInstance(vmId);
for (VolumeVO volume : volumes) {
if (volume != null && volume.getPassphraseId() != null) {
throw new CloudRuntimeException("VM has encrypted volumes, backup offering assignment is not allowed");
}
}

abh1sar Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Move this to NasBackupProvider.java in backupProvider.assignVMToBackupOffering.

We want to disable backup for encrypted volume for just nas backup provider.

abh1sar Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@sureshanaparti ^

Damans227 reviewed Jul 21, 2026
View reviewed changes
Comment thread server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java
when(volume.getPassphraseId()).thenReturn(42L);

try (MockedStatic<UsageEventUtils> ignored2 = Mockito.mockStatic(UsageEventUtils.class)) {
backupManager.assignVMToBackupOffering(vmId, offeringId);

Damans227 Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: assignVMToBackupOffering is expected to throw here, so the verify(vmInstanceDao, times(1)).findById(vmId) call right after it is unreachable, dead code.

DaanHoogland moved this from Backlog to conflict/waiting in CloudStack Testing Sep 1, 2026
nvazquez modified the milestones: 4.22.2, 4.22.3 Nov 9, 2026

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

abh1sar abh1sar requested changes
+2 more reviewers
Damans227 Damans227 left review comments
GaOrtiga GaOrtiga approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:backup status:waiting-for-author

Projects

CloudStack Testing
Status: conflict/waiting

Milestone

4.22.3

Development

Successfully merging this pull request may close these issues.

Don't allow NAS backup for vm with encrypted volumes

8 participants

Back | FazBrowse Home | New Git URL