FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Addition of the status filter in the backup listing API by GeanJair · Pull Request #13254 · apache/cloudstack · GitHub

/ cloudstack Public

Addition of the status filter in the backup listing API - #13254

Merged
DaanHoogland merged 3 commits into
apache:mainfrom
scclouds:add-filter-by-status
Jul 3, 2026
ConversationCommits (3)ChecksFiles changed
Merged

Addition of the status filter in the backup listing API #13254
DaanHoogland merged 3 commits into
apache:mainfrom
scclouds:add-filter-by-status

Conversation

GeanJair commented May 26, 2026

Copy link
Copy Markdown
Contributor

Description

Currently, the listBackups API does not allow listing backups based on their status. Changes have been made to the API to allow backups to be listed informing a specific status. In addition, the backups filter of the graphical interface has been extended to support the search based on status.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

The PR was tested by verifying both via CloudMonkey and the graphical interface the possibility of filtering backups by status.

How did you try to break this feature and the system with this change?

I tried to break this feature by passing an invalid status in both the CloudMonkey and the browser URL. In the API response a message was returned informing that the passed value is an invalid status.

DaanHoogland reviewed May 26, 2026
View reviewed changes
Comment thread ui/package-lock.json
GeanJair force-pushed the add-filter-by-status branch from 9fa3f09 to b058f0a Compare May 26, 2026 19:21

codecov Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.14%. Comparing base (d2c8aa7) to head (fe52050).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 8.33% 11 Missing ⚠️
...dstack/api/command/user/backup/ListBackupsCmd.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13254      +/-   ##
============================================
+ Coverage     18.93%   20.14%   +1.20%     
- Complexity    18471    18472       +1     
============================================
  Files          6221     5751     -470     
  Lines        560045   519387   -40658     
  Branches      68289    60627    -7662     
============================================
- Hits         106048   104614    -1434     
+ Misses       442372   403344   -39028     
+ Partials      11625    11429     -196
Flag Coverage Δ
uitests ?
unittests 20.14% <6.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GeanJair changed the title adding backup filter by status Addition of the status filter in the backup listing API May 27, 2026
DaanHoogland approved these changes May 28, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm (uma pergunta)

Comment thread ui/public/locales/pt_BR.json
bernardodemarco approved these changes May 28, 2026
View reviewed changes

bernardodemarco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@GeanJS, code lgtm. I've just left one comment/suggestion here

Comment thread ui/src/components/widgets/Status.vue Outdated
Update ui/src/components/widgets/Status.vue
3384c91 
Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>
erikbocks approved these changes May 29, 2026
View reviewed changes

erikbocks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM. Didn't test it.

weizhouapache added this to the 4.23.0 milestone Jun 29, 2026
weizhouapache approved these changes Jun 29, 2026
View reviewed changes

weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code lgtm

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache commented Jun 30, 2026

Copy link
Copy Markdown
Member

@GeanJS
could you fix the conflicts ?

Tonitzpp approved these changes Jun 30, 2026
View reviewed changes

Tonitzpp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM

apache deleted a comment from blueorangutan Jul 2, 2026
apache deleted a comment from blueorangutan Jul 2, 2026
apache deleted a comment from blueorangutan Jul 2, 2026
apache deleted a comment from blueorangutan Jul 2, 2026

DaanHoogland commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Jul 2, 2026

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Jul 2, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18439

DaanHoogland commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Jul 2, 2026

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Jul 3, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-16471)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50286 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13254-t16471-kvm-ol8.zip
Smoke tests completed. 152 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

DaanHoogland merged commit 2032bbd into apache:main Jul 3, 2026
24 of 27 checks passed

boring-cyborg Bot commented Jul 3, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

abh1sar mentioned this pull request Jul 6, 2026
Merged

shwstppr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@DaanHoogland cc @GeanJair UI build started failing (probably some test issue) with this. Maybe we need to be a bit more watchful

weizhouapache mentioned this pull request Jul 7, 2026
Merged
14 tasks
weizhouapache pushed a commit that referenced this pull request Jul 7, 2026
UI: Fix missing label.allocated key in Status widget test mock (#13546)
4d006b5 
PR #13254 added an 'allocated' case to Status.vue getText() that calls
$t('label.allocated'), but did not update the test mock data, causing
two Allocated badge tests to fail in CI.
jmsperu mentioned this pull request Aug 24, 2026
Open
14 tasks
abh1sar added a commit that referenced this pull request Aug 27, 2026
backup: drop unused backupStatus search condition from listBackups
f513c2a 
The backupStatus condition was carried over from main, where #13254 added a
status filter to listBackups. 4.22 has neither ListBackupsCmd.getBackupStatus()
nor a setParameters call for it, so the condition is never populated and
SearchCriteria.getWhereClause() skips it. Dead code on this branch; the
statusNeq clause that hides tombstoned chain members is the one in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
weizhouapache weizhouapache approved these changes
bernardodemarco bernardodemarco approved these changes
+2 more reviewers
erikbocks erikbocks approved these changes
Tonitzpp Tonitzpp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:api component:backup component:UI

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL