improved errorlog message by adding null check by saurabhkushwaha438 · Pull Request #13263 · apache/cloudstack · GitHub

Implemented defensive null checks to prevent secondary NullPointerExceptions from masking the original VM import failure reason during VMware-to-KVM migration. for issue #13007

Changes made:

UnmanagedVMsManagerImpl.java
- Added a null guard before invoking updateImportVMTaskErrorState(...) inside the CloudRuntimeException catch block.
ImportVmTasksManagerImpl.java
- Added an early return in updateImportVMTaskErrorState(...) when the provided task object is null.

These changes ensure that the original import/conversion failure (for example missing virt-v2v or nbdkit-vddk on the target KVM host) is preserved and propagated correctly to the UI instead of being hidden by a secondary NPE during task error handling.

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.40%. Comparing base (d3f0700) to head (15c33ac).
⚠️ Report is 103 commits behind head on main.

Files with missing lines	Patch %	Lines
...apache/cloudstack/vm/ImportVmTasksManagerImpl.java	0.00%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13263   +/-   ##
=========================================
  Coverage     20.39%   20.40%           
- Complexity    21283    21284    +1     
=========================================
  Files          6481     6481           
  Lines        588040   588049    +9     
  Branches      72021    72021           
=========================================
+ Hits         119957   119978   +21     
+ Misses       455052   455042   -10     
+ Partials      13031    13029    -2

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	21.70% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pull request overview

This PR prevents secondary NullPointerExceptions from masking the original VM import/conversion failure during VMware-to-KVM migration, so the UI/API can surface the real error (e.g., missing virt-v2v / nbdkit-vddk) as described in issue #13007.

Changes:

Add a null guard before calling updateImportVMTaskErrorState(...) from the VM import failure handler.
Add an early return in updateImportVMTaskErrorState(...) when the provided task is null.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	Avoids triggering a secondary NPE while handling a CloudRuntimeException during import.
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java	Makes task error-state updates resilient to null task objects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

@nvazquez , @DaanHoogland could you approve workflow and review pull request

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Hi @nvazquez , I've resolved the merge conflicts and updated this PR with the latest main. The CI has been rerun. I'd appreciate a review whenever you have time. Thank you!

@blueorangutan package

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19217

@blueorangutan test

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian Build Failed (tid-16974)

…g logs B

@saurabhkushwaha438 thanks for taking care of the conflicts. Could you answer the co-pilot's remaining remarks, please?

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19630

@DaanHoogland i have resolved the remaining conversation . also do i need to add unit tests for ImportVmTasksManagerImpl so that will fix codecov/patch and Sonar JaCoCo Coverage

@blueorangutan test

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-17235)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57163 seconds
Marvin logs: [archive removed]
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

Code LGTM

@blueorangutan package

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20020

LGTM

Tested on a KVM env (mgmt + 2 EL9 KVM hosts), baseline on current main build first, then the PR build (24.0.0-shapeblue22166).

importVm VMware to KVM on a host without virt-v2v/nbdkit-vddk (the #13007 case): real error shown, no NPE. Note: same result on main already, because the caller has had the if (importVMTask != null) guard since #13656/#14256, so the new check in updateImportVMTaskErrorState is an extra safety net.
importVm with usevddk=false against an unreachable vCenter (task created, then fails): real error returned, task saved as Failed with the error.
Debug log fix confirmed. Main: "VM: qa-src-vm ... vCenter: qa13263-base2 / datacenter: 10.0.99.99 / source VM: qa-dc" (shifted). PR: "VM: qa13263-pr2 ... vCenter: 10.0.99.99 / datacenter: qa-dc / source VM: qa-src-vm" (correct).
Regression: listImportVMTasks with failed/running/completed filters OK, invalid filter returns "Invalid value for task state", hosts Up, VM stop/start OK.

DaanHoogland requested review from Copilot and nvazquez and removed request for nvazquez May 27, 2026 13:07

Copilot started reviewing on behalf of DaanHoogland May 27, 2026 13:07

View session

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java Resolved

Comment thread server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java Resolved

saurabhkushwaha438 force-pushed the improved-errorlog-message branch from afeae99 to 5f54d85 Compare May 27, 2026 17:04

DaanHoogland requested a review from Copilot May 28, 2026 07:30

Copilot started reviewing on behalf of DaanHoogland May 28, 2026 07:31

View session

Copilot AI reviewed May 28, 2026

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java Resolved

Comment thread server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java Resolved

Comment thread server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java Resolved

github-actions Bot mentioned this pull request Jun 13, 2026

[repo-status] Daily Status Report — June 13, 2026 #13416

Closed

github-actions Bot mentioned this pull request Jun 16, 2026

[repo-status] Daily Status Report — June 16, 2026 #13435

Closed

github-actions Bot added the status:has-conflicts label Jun 30, 2026

github-actions Bot removed the status:has-conflicts label Aug 7, 2026

DaanHoogland added this to the 4.24.0 milestone Aug 10, 2026

DaanHoogland added this to CloudStack Testing Aug 10, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 10, 2026

DaanHoogland added the status:needs-testing label Aug 10, 2026

DaanHoogland moved this from Backlog to Ready in CloudStack Testing Aug 31, 2026

DaanHoogland assigned borisstoyanov Sep 1, 2026

saurabhkushwaha438 added 3 commits October 16, 2026 10:59

improved errorlog message by adding null check

6a11bad

ui: centralize importVMTask null guard in task manager and add warnin…

2f2bbd7

…g logs B

Fix debug log placeholder argument mapping in ImportVmTasksManagerImpl

15c33ac

saurabhkushwaha438 force-pushed the improved-errorlog-message branch from 719f731 to 15c33ac Compare October 16, 2026 08:42

github-actions Bot removed the status:has-conflicts label Oct 16, 2026

DaanHoogland linked an issue Nov 8, 2026 that may be closed by this pull request

Ui : Improve the error log message #13007

Closed

nvazquez requested review from Damans227 and RosiKyu November 11, 2026 15:18

nvazquez approved these changes Nov 11, 2026

View reviewed changes

nvazquez requested a review from kiranchavala November 11, 2026 15:21

nvazquez mentioned this pull request Nov 11, 2026

Ui : Improve the error log message #13007

Closed

RosiKyu assigned RosiKyu and unassigned borisstoyanov Nov 12, 2026

RosiKyu added status:tested and removed status:needs-testing labels Nov 12, 2026

RosiKyu approved these changes Nov 12, 2026

View reviewed changes

RosiKyu merged commit a8200cf into apache:main Nov 12, 2026
23 of 27 checks passed

github-project-automation Bot moved this from Ready to Done in CloudStack Testing Nov 12, 2026

improved errorlog message by adding null check by saurabhkushwaha438 · Pull Request #13263 · apache/cloudstack · GitHub

Repository navigation

improved errorlog message by adding null check - #13263

improved errorlog message by adding null check#13263RosiKyu merged 3 commits intoapache:mainapache/cloudstack:mainfrom saurabhkushwaha438:improved-errorlog-messagesaurabhkushwaha438/cloudstack:improved-errorlog-messageCopy head branch name to clipboard

Conversation

saurabhkushwaha438 commented May 27, 2026

Uh oh!

codecov Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saurabhkushwaha438 commented Jun 16, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

saurabhkushwaha438 commented Aug 7, 2026

Uh oh!

borisstoyanov commented Sep 11, 2026

Uh oh!

blueorangutan commented Sep 11, 2026

Uh oh!

blueorangutan commented Sep 11, 2026

Uh oh!

borisstoyanov commented Sep 11, 2026

Uh oh!

blueorangutan commented Sep 11, 2026

Uh oh!

blueorangutan commented Sep 11, 2026

Uh oh!

DaanHoogland commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Oct 20, 2026

Uh oh!

blueorangutan commented Oct 20, 2026

Uh oh!

blueorangutan commented Oct 20, 2026

Uh oh!

saurabhkushwaha438 commented Oct 23, 2026

Uh oh!

nvazquez commented Oct 23, 2026

Uh oh!

blueorangutan commented Oct 23, 2026

Uh oh!

blueorangutan commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Nov 11, 2026

Uh oh!

RosiKyu commented Nov 12, 2026

Uh oh!

blueorangutan commented Nov 12, 2026

Uh oh!

blueorangutan commented Nov 12, 2026

Uh oh!

RosiKyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

improved errorlog message by adding null check#13263
RosiKyu merged 3 commits into
apache:mainfrom
saurabhkushwaha438:improved-errorlog-message

codecov Bot commented May 27, 2026 •
edited
Loading

DaanHoogland commented Oct 20, 2026 •
edited
Loading

blueorangutan commented Oct 24, 2026 •
edited
Loading