FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove the duplicate configkey json.content.type by sureshanaparti · Pull Request #13264 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Remove the duplicate configkey json.content.type - #13264

Merged
winterhazel merged 2 commits into
apache:4.20from
shapeblue:remove-duplicate-configkey-json.content.type
Jun 11, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Remove the duplicate configkey json.content.type#13264
winterhazel merged 2 commits into
apache:4.20from
shapeblue:remove-duplicate-configkey-json.content.type

Conversation

sureshanaparti commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR removes the duplicate configkey json.content.type. Preserved the same description for the config as now in the CloudStack deployment.

The config key was added twice here: https://github.com/apache/cloudstack/pull/2848/files#diff-d4f381fc49d5bb07c76daf73677484cace911ff56eb08e60b253b6ef0273124d (in 4.12.0.0) and one config key is unused.

mysql> SELECT * FROM cloud.configuration WHERE name = 'json.content.type'\G;
*************************** 1. row ***************************
     category: Advanced
     instance: DEFAULT
    component: ApiServer
         name: json.content.type
        value: application/json; charset=UTF-8
  description: Http response content type for JSON
default_value: application/json; charset=UTF-8
      updated: 2026-05-06 15:55:35
   is_dynamic: 0
     group_id: 1
  subgroup_id: 1
       parent: NULL
 display_text: Json content type
         kind: NULL
      options: NULL
        scope: 1
1 row in set (0.01 sec)

mysql> SELECT * FROM cloud.configuration WHERE description LIKE '%Http response content%'\G;
*************************** 1. row ***************************
     category: Advanced
     instance: DEFAULT
    component: ApiServer
         name: json.content.type
        value: application/json; charset=UTF-8
  description: Http response content type for JSON
default_value: application/json; charset=UTF-8
      updated: 2026-05-06 15:55:35
   is_dynamic: 0
     group_id: 1
  subgroup_id: 1
       parent: NULL
 display_text: Json content type
         kind: NULL
      options: NULL
        scope: 1
1 row in set (0.01 sec)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti added this to the 4.20.4 milestone May 27, 2026

sureshanaparti commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented May 27, 2026

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (c267ad3) to head (ad6465d).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines Patch % Lines
server/src/main/java/com/cloud/api/ApiServlet.java 40.00% 5 Missing and 1 partial ⚠️
server/src/main/java/com/cloud/api/ApiServer.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #13264      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
  Complexity    13433    13433              
============================================
  Files          5665     5666       +1     
  Lines        500572   500644      +72     
  Branches      60792    60801       +9     
============================================
+ Hits          81417    81423       +6     
- Misses       410047   410113      +66     
  Partials       9108     9108
Flag Coverage Δ
uitests 4.14% <ø> (-0.01%) ⬇️
unittests 17.11% <41.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan commented May 27, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18061

DaanHoogland approved these changes May 28, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

sureshanaparti commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Jun 2, 2026

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Jun 2, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18121

winterhazel commented Jun 11, 2026

Copy link
Copy Markdown
Member

@DaanHoogland @sureshanaparti @Pearl1594 can we run the CI here?

Pearl1594 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Jun 11, 2026

Copy link
Copy Markdown

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

winterhazel approved these changes Jun 11, 2026
View reviewed changes

winterhazel left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks ok. I validated that the configuration is still respected correctly.

Edit: oops, hurried myself on merging this one before the CI.

winterhazel merged commit d35c1cd into apache:4.20 Jun 11, 2026
25 of 26 checks passed
github-actions Bot mentioned this pull request Jun 11, 2026
Closed

blueorangutan commented Jun 12, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-16287)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54410 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13264-t16287-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

This was referenced Jun 12, 2026
Closed
Closed
Closed
Closed
dhslove mentioned this pull request Sep 10, 2026
Closed
5 tasks done
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 10, 2026
Remove the duplicate configkey json.content.type (apache#13264)
5125d0a 
(cherry picked from commit d35c1cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
winterhazel winterhazel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL