FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update nw_rate & mc_rate to int unsigned to allow rates > 65Gbps by Pearl1594 · Pull Request #13380 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Update nw_rate & mc_rate to int unsigned to allow rates > 65Gbps - #13380

Merged
harikrishna-patnala merged 8 commits into
mainfrom
update-dbtype-nwrate
Jul 6, 2026
ConversationCommits (8)ChecksFiles changed
Merged

Update nw_rate & mc_rate to int unsigned to allow rates > 65Gbps#13380
harikrishna-patnala merged 8 commits into
mainfrom
update-dbtype-nwrate

Conversation

Pearl1594 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes: #13355

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Pearl1594 requested a review from weizhouapache June 8, 2026 19:25

codecov Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.93%. Comparing base (d2c8aa7) to head (2d6d937).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13380      +/-   ##
============================================
- Coverage     18.93%   18.93%   -0.01%     
- Complexity    18471    18476       +5     
============================================
  Files          6221     6221              
  Lines        560045   560088      +43     
  Branches      68289    68288       -1     
============================================
+ Hits         106048   106054       +6     
- Misses       442372   442410      +38     
+ Partials      11625    11624       -1
Flag Coverage Δ
uitests 3.50% <ø> (ø)
unittests 20.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions Bot mentioned this pull request Jun 8, 2026
Closed

weizhouapache commented Jun 9, 2026

Copy link
Copy Markdown
Member

code lgtm

I just wonder if the sql is in correct uprgade file.
if we release 4.23.0 now, the changes will not apply to 4.23.0 users.
I think we should avoid sql changes of minor releases, especially when a new major version is released.

Pearl1594 force-pushed the update-dbtype-nwrate branch from 6a1355a to 6ed9170 Compare June 16, 2026 16:48
Pearl1594 changed the base branch from 4.22 to main June 16, 2026 16:48

blueorangutan commented Jul 1, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-16453)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49130 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13380-t16453-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Apply suggestion from @DaanHoogland
2d6d937 
Co-authored-by: dahn <daan@onecht.net>
Copilot AI reviewed Jul 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql Resolved
weizhouapache approved these changes Jul 6, 2026
View reviewed changes

weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code lgtm

weizhouapache commented Jul 6, 2026

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Jul 6, 2026

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 23.57%
Branch coverage 17.80%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

blueorangutan commented Jul 6, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18471

harikrishna-patnala approved these changes Jul 6, 2026
View reviewed changes

harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
DaanHoogland DaanHoogland approved these changes
harikrishna-patnala harikrishna-patnala approved these changes
winterhazel winterhazel approved these changes
weizhouapache weizhouapache approved these changes
+1 more reviewer
github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

Change network_rate type to unsigned int from unsigned smallint - to allow network rate > 65Gbps

8 participants

Back | FazBrowse Home | New Git URL