Description

LibvirtStorageAdapter used to identify the poolType for a Shared mount point storage as StoragePoolType.Filesystem as it derived it from LIbvirt's XML where both Local Storage and SMP map to the PoolType.Dir.

So it used to have the same behaviour as Local Storage and NFS as there are some conditions that only check these two storages:

        if (StoragePoolType.NetworkFilesystem.equals(poolType) || StoragePoolType.Filesystem.equals(poolType)) {

#12773 (4.22.1) changed this to set the poolType as SharedMountPoint.

        if (pool instanceof LibvirtStoragePool) {
            addPoolDetails(uuid, (LibvirtStoragePool) pool);
+            ((LibvirtStoragePool) pool).setType(type);
        }

It causes Shared Mount Point to be excluded from a few places in code.

This creates a few problems:

1. Encryption not being applied to the volumes .

2. Qcow2 being created with compat=0.10 or version2 instead of 3.
   This is because disk creation is now being done using createPhysicalDiskByLibVirt instead of createPhysicalDiskByQemuImg

3. Migrating a VM from NFS to SMP storage fails
   This is because createDiskFromTemplateBacking returns now for SMP

    public KVMPhysicalDisk createDiskFromTemplateBacking(KVMPhysicalDisk template, String name, PhysicalDiskFormat format, long size,
                                                         KVMStoragePool destPool, int timeout, byte[] passphrase) {
        String volumeDesc = String.format("volume [%s], with template backing [%s], in pool [%s] (%s), with size [%s] and encryption is %s", name, template.getName(), destPool.getUuid(),
          destPool.getType(), size, passphrase != null && passphrase.length > 0);

        if (!poolTypesThatEnableCreateDiskFromTemplateBacking.contains(destPool.getType())) {
            logger.info(String.format("Skipping creation of %s due to pool type is none of the following types %s.", volumeDesc, poolTypesThatEnableCreateDiskFromTemplateBacking.stream()
              .map(type -> type.toString()).collect(Collectors.joining(", "))));

            return null;
        }

Fix

Extract NetworkFilesystem/Filesystem/SharedMountPoint into a single QEMU_IMG_MANAGED_POOL_TYPES constant and route SharedMountPoint through the same qemu-img-based creation path as NFS/Filesystem everywhere that set is consulted.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested the 3 failing test cases with and without the fix.

How did you try to break this feature and the system with this change?