FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: honor skipTests in plugins/storage/volume/ontap/pom.xml by weizhouapache · Pull Request #13609 · apache/cloudstack · GitHub

/ cloudstack Public

test: honor skipTests in plugins/storage/volume/ontap/pom.xml - #13609

Closed
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.23-honor-skiptests-ontap
ConversationCommits (1)ChecksFiles changed
Closed

test: honor skipTests in plugins/storage/volume/ontap/pom.xml#13609
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.23-honor-skiptests-ontap

Conversation

weizhouapache commented Jul 14, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes the issue that unit tests in plugins/storage/volume/ontap/ are always executed, even if -DskipTests flag is passed.

For users who build the the project with java 21, please pass -DskipTests flag, as the unit tests in plugins/storage/volume/ontap/ is not compatible with java 21 which will be fixed in next release.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI review requested due to automatic review settings July 14, 2026 08:12
weizhouapache added this to the 4.23.0 milestone Jul 14, 2026
weizhouapache marked this pull request as draft July 14, 2026 08:14

weizhouapache commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

this PR is not required if #13578 is merged

codecov Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.50%. Comparing base (24fd90a) to head (098e96b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #13609   +/-   ##
=========================================
  Coverage     19.50%   19.50%           
- Complexity    19438    19441    +3     
=========================================
  Files          6303     6303           
  Lines        569288   569288           
  Branches      69792    69792           
=========================================
+ Hits         111028   111034    +6     
+ Misses       446106   446100    -6     
  Partials      12154    12154
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI reviewed Jul 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR updates the ONTAP plugin’s Maven test configuration so that the module respects Maven’s standard -DskipTests behavior instead of forcing tests to always run.

Changes:

  • Removed the hardcoded Surefire <skipTests>false</skipTests> override in plugins/storage/volume/ontap/pom.xml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/storage/volume/ontap/pom.xml
Comment on lines 165 to 168
<configuration>
<skipTests>false</skipTests>
<includes>
<include>**/*Test.java</include>
</includes>
DaanHoogland deleted the 4.23-honor-skiptests-ontap branch July 16, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

component:build component:primary-storage component:storage

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL