FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use correct ID to get value of backup.validation.script.default.timeout by JoaoJandre · Pull Request #13652 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Use correct ID to get value of backup.validation.script.default.timeout - #13652

Merged
winterhazel merged 2 commits into
apache:mainfrom
scclouds:small-kboss-fix
Jul 20, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Use correct ID to get value of backup.validation.script.default.timeout#13652
winterhazel merged 2 commits into
apache:mainfrom
scclouds:small-kboss-fix

Conversation

JoaoJandre commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes #12758 (comment)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

JoaoJandre requested a review from winterhazel July 20, 2026 12:10
JoaoJandre mentioned this pull request Jul 20, 2026
Merged
2 of 14 tasks

codecov Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (75748a5) to head (765e561).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13652      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19784       -8     
============================================
  Files          6368     6368              
  Lines        575107   575107              
  Branches      70370    70370              
============================================
- Hits         113016   112971      -45     
- Misses       449808   449853      +45     
  Partials      12283    12283
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.91% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoaoJandre commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Jul 20, 2026

Copy link
Copy Markdown

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

winterhazel commented Jul 20, 2026

Copy link
Copy Markdown
Member

@weizhouapache as this is a small and zero risk follow-up for #12758, I am including it in 4.23 RC2.

winterhazel added this to the 4.23.0 milestone Jul 20, 2026

blueorangutan commented Jul 20, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18622

winterhazel approved these changes Jul 20, 2026
View reviewed changes

winterhazel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tested. It looks ok.

I verified that the default timeout configured at the account for the backup validation script level is now correctly obtained.

Configured account-level value used as the default validation script timeout

The new description for quiescevm is also ok.

Updated description for quiescevm

bernardodemarco approved these changes Jul 20, 2026
View reviewed changes

bernardodemarco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code lgtm

winterhazel merged commit fc83241 into apache:main Jul 20, 2026
24 of 27 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 11, 2026
Use correct ID to get value of backup.validation.script.default.timeo…
77ebf97 
…ut (apache#13652)

(cherry picked from commit fc83241)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

winterhazel winterhazel approved these changes
bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

component:api component:backup

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL