test: read and set nas.backup.incremental.enabled for the test zone - #13960
test: read and set nas.backup.incremental.enabled for the test zone#13960jmsperu wants to merge 1 commit into
Conversation
Sorry, something went wrong.
nas.backup.incremental.enabled is a zone-scoped setting, but test_backup_recovery_nas.py read and updated it without a zoneid, so a zone override in the test environment would make the suite read the wrong value. Pass zoneid=cls.zone.id on the read and on both updates, as the other backup smoke tests do for zone-scoped settings. Noted by the Copilot review on the 4.22 backport (apache#13877). Signed-off-by: James Peru <jmsperu@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13960 +/- ##
============================================
- Coverage 19.73% 19.73% -0.01%
+ Complexity 19956 19954 -2
============================================
Files 6371 6371
Lines 575765 575765
Branches 70478 70478
============================================
- Hits 113642 113632 -10
- Misses 449766 449779 +13
+ Partials 12357 12354 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Sorry, something went wrong.
|
@jmsperu |
Sorry, something went wrong.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19000 |
Sorry, something went wrong.
Description
nas.backup.incremental.enabled is a zone-scoped setting, but test_backup_recovery_nas.py read and updated it without a zoneid, so a zone override in the test environment would make the suite read the wrong value (and restore the wrong one in tearDownClass). This passes zoneid=cls.zone.id on the read and on both updates, the same way test_backup_recovery_veeam.py handles zone-scoped settings.
Noted by the Copilot review on the 4.22 backport #13877; this is the main-side fix so both branches stay in sync.
Types of changes
How Has This Been Tested?
Python syntax check; the change is limited to three Marvin calls in setUpClass/tearDownClass.