Repository navigation
Add pre-commit hook to validate dependabot.yml - #14107
nvazquez merged 4 commits into
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14107 +/- ##
=========================================
Coverage 19.89% 19.89%
- Complexity 20141 20143 +2
=========================================
Files 6371 6371
Lines 576829 576829
Branches 70627 70627
=========================================
+ Hits 114756 114777 +21
+ Misses 449531 449507 -24
- Partials 12542 12545 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Adds a pre-commit hook to validate .github/dependabot.yml using check-jsonschema, ensuring Dependabot configuration changes are caught early in local workflows and CI.
Changes:
- Adds python-jsonschema/check-jsonschema to pre-commit repos.
- Enables the check-dependabot hook scoped to the Dependabot config file.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is a low-risk pre-commit configuration update and the only feedback is a minor hook-name clarity nit.
Review details- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Sorry, something went wrong.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, follows existing pre-commit pinning conventions, and correctly targets the Dependabot config with the intended offline validator.
Review details- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Sorry, something went wrong.
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm
Sorry, something went wrong.
|
@vishesh92 @weizhouapache can you review/merge? |
Sorry, something went wrong.
nvazquez
left a comment
There was a problem hiding this comment.
Code LGTM - also pre-commit check passed
Sorry, something went wrong.
* origin/main: (156 commits) Upgrade Netris SDK version to 1.1.0 since 24.0 (apache#14365) feature: instance boot group and readiness rules (apache#13907) dont show unathorized notification for prelogin (apache#14054) .github: Upgrade docker/login-action to fix ASF Allowlist failure (apache#14276) virtual router: Add route-maps to BGP peers for Routed Mode (apache#9964) Add pre-commit hook to validate dependabot.yml (apache#14107) Add the ASF Allowlist check workflow (apache#14113) Revert "VMware to KVM: cold (VDDK) and warm (CBT) migration into Ceph/RBD and Linstor, plus importVm adoption of existing RBD root volumes and Linstor root/data volumes (apache#13656)" VMware to KVM: cold (VDDK) and warm (CBT) migration into Ceph/RBD and Linstor, plus importVm adoption of existing RBD root volumes and Linstor root/data volumes (apache#13656) engine-schema: upgrade path for 24.0.0 (apache#14033) xenserver/xcpng: do not bypass secondary storage when copy volumes between pools (apache#13750) backport: Incremental NAS backup support for KVM (apache#13074) (apache#13877) storage: KVM - enable RBD/Ceph volume encryption support (apache#13556) backup: remove the powered-off precondition for all backup providers (apache#14094) Nas backup: Fix mount/unmount error handling and timeout in LibvirtRestoreBackupCommandWrapper (apache#14006) kvm: apply rbd_default_data_pool when creating volumes from templates on RBD (apache#13361) server: copy template details to vm instance details when import VM (apache#12793) marvin: use pycryptodome instead of PyCrypt (apache#13594) Packaging: accept normalized Marvin archive names (apache#13793) SharedFS: fix NPE when accessing systemvm templates for unsupported hypervisors (apache#13930) ...
https://check-jsonschema.readthedocs.io/en/stable/precommit_usage.html#check-dependabot
python-jsonschema/check-jsonschema@12e6394
Description
This PR closes #14088
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran:
How did you try to break this feature and the system with this change?