FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

orchestration: apply custom IOPS to root volumes by xujiantop-crypto · Pull Request #14114 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

orchestration: apply custom IOPS to root volumes - #14114

Open
xujiantop-crypto wants to merge 1 commit into
apache:4.20from
xujiantop-crypto:fix/root-volume-custom-iops
ConversationCommits (1)ChecksFiles changed
Open

orchestration: apply custom IOPS to root volumes#14114
xujiantop-crypto wants to merge 1 commit into
apache:4.20from
xujiantop-crypto:fix/root-volume-custom-iops

Conversation

xujiantop-crypto commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Custom root disk IOPS are stored in VM details as minIops and maxIops. CloudOrchestrator was reading the API parameter names miniops and maxiops, so the values were not propagated to the root DiskOfferingInfo during VM deployment from a template.

This change:

  • adds canonical VM-detail constants for minIops and maxIops
  • uses those constants when building the root disk offering
  • adds a regression test that verifies custom root IOPS reach the VM allocation call

Fixes #14103

Testing

mvn -pl engine/orchestration -am -Dtest=CloudOrchestratorTest -DfailIfNoTests=false test
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
33/33 reactor modules SUCCESS
Checkstyle: 0 violations

orchestration: apply custom IOPS to root volumes
41acb91 
Signed-off-by: xujiantop-crypto <265865031+xujiantop-crypto@users.noreply.github.com>

codecov Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.37%. Comparing base (6e4413d) to head (41acb91).
⚠️ Report is 4 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #14114      +/-   ##
============================================
+ Coverage     16.36%   16.37%   +0.01%     
- Complexity    13592    13599       +7     
============================================
  Files          5669     5669              
  Lines        501475   501475              
  Branches      60913    60913              
============================================
+ Hits          82067    82128      +61     
+ Misses       410209   410137      -72     
- Partials       9199     9210      +11
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland linked an issue Sep 10, 2026 that may be closed by this pull request
Custom IOPS not applied to root disk when deploying a VM from a template #14103
Open
DaanHoogland added this to the 4.20.4 milestone Sep 10, 2026

rajiv-jain-netapp commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

can you put some UI screenshots where you find these workflows working?

DaanHoogland mentioned this pull request Sep 30, 2026
Open

DaanHoogland commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

tested by reporter (see #14103 (comment))

DaanHoogland approved these changes Oct 7, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

Damans227 reviewed Oct 7, 2026
View reviewed changes
Comment thread ...rchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
if (userVmDetails != null) {
String minIops = userVmDetails.get(MIN_IOPS);
String maxIops = userVmDetails.get(MAX_IOPS);
String minIops = userVmDetails.get(VmDetailConstants.MIN_IOPS);

Damans227 Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should the min and max check on deploy use these new names too? it still looks up the old ones, so a min above max now reaches the volume without an error

DaanHoogland Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Damans227 what change are you suggesting (if any)?

Damans227 Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the check that stops a min above max on deploy is in UserVmManagerImpl, and it still looks up miniops and maxiops. i suggest it reads the new minIops and maxIops names too, so a bad pair errors out instead of reaching the volume.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
+1 more reviewer
Damans227 Damans227 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:api component:orchestration

Projects

CloudStack Testing
Status: Backlog

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

Custom IOPS not applied to root disk when deploying a VM from a template

4 participants

Back | FazBrowse Home | New Git URL