SSVM: entity download URL creation: ensure userdata base dir exists by DaanHoogland · Pull Request #14447 · apache/cloudstack · GitHub

replaces #13967, as the author won't rebase

When handleCreateEntityURLCommand runs on the SSVM it builds the download URL by creating /var/www/html/userdata// as the www-data user (su www-data -c "mkdir -p ..."). On stock systemvm templates the /var/www/html/userdata base directory does not exist and /var/www/html is not writable by www-data, so the mkdir fails with "Permission denied" and getDiagnosticsData / extractVolume / extractTemplate async jobs error out with code 530 and no download URL is produced.

Fix: create the base extract directory and set its ownership to www-data before dropping privileges to create the per-entity subdirectory. This makes the SSVM self-healing on first use and matches the directory layout expected by the Apache docroot.

Fixes: #13959

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

BLOCKER
Critical
Major
Minor
Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Codecov Report

❌ Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.32%. Comparing base (d02adcd) to head (f5c2384).

Files with missing lines	Patch %	Lines
...cloudstack/storage/template/UploadManagerImpl.java	45.00%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #14447   +/-   ##
=========================================
  Coverage     18.32%   18.32%           
- Complexity    16644    16647    +3     
=========================================
  Files          5939     5939           
  Lines        537768   537787   +19     
  Branches      65929    65932    +3     
=========================================
+ Hits          98551    98555    +4     
- Misses       428008   428022   +14     
- Partials      11209    11210    +1

Flag	Coverage Δ
uitests	4.08% <ø> (ø)
unittests	19.41% <45.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

Building a bash -c command via string concatenation can introduce shell parsing/injection issues… · New
This will chown the base directory on every URL creation attempt, which can be unnecessarily… · New
The error message doesn’t include the failing path (BASE_EXTRACT_PATH), which makes diagnosis… · New

What changed in this PR

Ensures SSVM download URL creation succeeds on stock templates by creating the missing /var/www/html/userdata/ base directory and making it writable by www-data before creating per-entity extract subdirectories.

Changes:

Create the base extract directory (BASE_EXTRACT_PATH) if missing.
Set ownership of the base extract directory to www-data:www-data before running mkdir as www-data.

File	Description
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/UploadManagerImpl.java	Ensures base extract directory exists and is owned by www-data to unblock per-entity directory creation and URL generation.

Review effort: Lite

@DaanHoogland are any of the copilot comments relevant here?

…s and is writable by www-data When handleCreateEntityURLCommand runs on the SSVM it builds the download URL by creating /var/www/html/userdata/<uuid>/ as the www-data user (su www-data -c "mkdir -p ..."). On stock systemvm templates the /var/www/html/userdata base directory does not exist and /var/www/html is not writable by www-data, so the mkdir fails with "Permission denied" and getDiagnosticsData / extractVolume / extractTemplate async jobs error out with code 530 and no download URL is produced. Fix: create the base extract directory and set its ownership to www-data before dropping privileges to create the per-entity subdirectory. This makes the SSVM self-healing on first use and matches the directory layout expected by the Apache docroot. References #13959

@sureshanaparti , updated.

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

clgtm

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
45.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19949

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

LGTM based on manual testing. Note: the problem is reproducible only after live patching the system VMs, a fresh one doesn't trigger it.

[SF] Trillian test result (tid-17515)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 73401 seconds
Marvin logs: not retained - PR was already closed when the run finished
Smoke tests completed. 145 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_primary_storage_nfs	Error	0.24	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	Error	0.39	test_primary_storage.py
test_01_primary_storage_scope_change	Error	0.14	test_primary_storage_scope.py
test_02_list_cpvm_vm	Failure	0.04	test_ssvm.py
test_04_cpvm_internals	Failure	0.06	test_ssvm.py
test_01_vpn_usage	Error	1.15	test_usage.py

DaanHoogland requested a balanced review from Copilot October 20, 2026 13:23

boring-cyborg Bot added component:secondary-storage component:ssvm labels Oct 20, 2026

DaanHoogland requested review from harikrishna-patnala, sureshanaparti, vishesh92 and vladimirpetrov October 20, 2026 13:24

This was referenced Oct 20, 2026

fix: SSVM entity download URL creation: ensure userdata base dir exists and is writable by www-data #13967

Closed

getDiagnosticsData fails: www-data cannot mkdir /var/www/html/userdata on SSVM (Permission denied) #13959

Closed

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Copilot stopped reviewing on behalf of DaanHoogland due to an error October 20, 2026 17:53
The job was not acquired by a runner even after multiple attempts.

DaanHoogland linked an issue Nov 9, 2026 that may be closed by this pull request

getDiagnosticsData fails: www-data cannot mkdir /var/www/html/userdata on SSVM (Permission denied) #13959

Closed

DaanHoogland added this to the 4.22.2 milestone Nov 9, 2026

nvazquez modified the milestones: 4.22.2, 4.22.3 Nov 9, 2026

DaanHoogland modified the milestones: 4.22.3, 4.22.2 Nov 9, 2026

waterWang and others added 2 commits November 9, 2026 14:20

ssvm: create userdata extract dir without a shell, only when needed

f5c2384

DaanHoogland force-pushed the ghi13959-fixSsvmEntityDownloadURL branch from a926799 to f5c2384 Compare November 9, 2026 13:28

sureshanaparti approved these changes Nov 9, 2026

View reviewed changes

sureshanaparti added the status:ready-for-testing label Nov 9, 2026

vladimirpetrov approved these changes Nov 10, 2026

View reviewed changes

DaanHoogland merged commit b56bbc2 into 4.22 Nov 10, 2026
66 of 67 checks passed

DaanHoogland deleted the ghi13959-fixSsvmEntityDownloadURL branch November 10, 2026 09:23

SSVM: entity download URL creation: ensure userdata base dir exists by DaanHoogland · Pull Request #14447 · apache/cloudstack · GitHub

Repository navigation

SSVM: entity download URL creation: ensure userdata base dir exists - #14447

SSVM: entity download URL creation: ensure userdata base dir exists#14447DaanHoogland merged 2 commits into4.22apache/cloudstack:4.22from ghi13959-fixSsvmEntityDownloadURLapache/cloudstack:ghi13959-fixSsvmEntityDownloadURLCopy head branch name to clipboard

Conversation

DaanHoogland commented Oct 20, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Nov 9, 2026

Uh oh!

DaanHoogland commented Nov 9, 2026

Uh oh!

DaanHoogland commented Nov 9, 2026

Uh oh!

blueorangutan commented Nov 9, 2026

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Nov 9, 2026

Quality Gate passed

Uh oh!

blueorangutan commented Nov 9, 2026

Uh oh!

DaanHoogland commented Nov 9, 2026

Uh oh!

blueorangutan commented Nov 9, 2026

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blueorangutan commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SSVM: entity download URL creation: ensure userdata base dir exists#14447
DaanHoogland merged 2 commits into
4.22from
ghi13959-fixSsvmEntityDownloadURL

codecov Bot commented Oct 20, 2026 •
edited
Loading