FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[CI] Switch to prek-action workflow by jbampton · Pull Request #14549 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

[CI] Switch to prek-action workflow - #14549

Closed
jbampton wants to merge 7 commits into
apache:mainfrom
jbampton:add-prek-action
ConversationCommits (7)ChecksFiles changed
Closed

[CI] Switch to prek-action workflow#14549
jbampton wants to merge 7 commits into
apache:mainfrom
jbampton:add-prek-action

Conversation

jbampton commented Nov 1, 2026

Copy link
Copy Markdown
Member

Add a separate workflow for the manual hooks

Description

This PR refs #14093

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[CI] Switch to prek-action workflow
1b7aa5d 
Add a separate workflow for the manual hooks
Copilot AI balanced review requested due to automatic review settings November 1, 2026 00:11
Copilot AI reviewed Nov 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🟡 Changes recommended

The manual workflow duplicates the Run pre-commit check name on pull requests, which can create ambiguous results and block merging if branch protection requires that check.

1 open issue What changed in this PR

This PR advances the migration from pre-commit to prek described in #14093 and separates manual-stage hooks into their own CI workflow.

Changes:

  • Replace explicit Python setup, installation, and caching with j178/prek-action.
  • Run manual-stage hooks in a separate pull-request workflow.
  • Update checkout and adjust cancellation behavior in both workflows.
File Description
.github/​workflows/​pre-commit.yml Switch normal hooks to prek-action and remove manual-stage execution.
.github/​workflows/​pre-commit-manual.yml Add a dedicated workflow for running manual-stage hooks with prek.

Review effort: Balanced

Comment thread .github/workflows/pre-commit-manual.yml Resolved
Copilot AI balanced review requested due to automatic review settings November 1, 2026 00:14
Copilot AI reviewed Nov 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🟢 Approval recommended

No active review issues are recorded for the migration to prek and separation of manual-stage hooks.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 1, 2026 00:21

codecov Bot commented Nov 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.78%. Comparing base (92e44bb) to head (140128a).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14549      +/-   ##
============================================
+ Coverage     20.76%   20.78%   +0.01%     
- Complexity    21905    21931      +26     
============================================
  Files          6496     6496              
  Lines        591605   591657      +52     
  Branches      72583    72592       +9     
============================================
+ Hits         122854   122966     +112     
+ Misses       455414   455346      -68     
- Partials      13337    13345       +8
Flag Coverage Δ
uitests 3.88% <ø> (ø)
unittests 22.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI reviewed Nov 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🟢 Approval recommended

No active review issues are reported for the migration to separate standard and manual-stage prek workflows.

No open issues 🎉

Review effort: Balanced

DaanHoogland linked an issue Nov 8, 2026 that may be closed by this pull request
Switch from pre-commit to prek #14093
Open
DaanHoogland added this to the 25.0 milestone Nov 8, 2026

DaanHoogland commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

@jbampton , the prek standard job fails (also after retried) can you have a look?

jbampton commented Nov 9, 2026
View reviewed changes
Comment thread .github/workflows/prek.yml Resolved
Copilot AI balanced review requested due to automatic review settings November 9, 2026 04:25
Copilot AI reviewed Nov 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🟢 Approval recommended

The pull-request hook migration from pre-commit to prek has no active review issues.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 9, 2026 04:34
Copilot AI reviewed Nov 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🟡 Changes recommended

The manual workflow can populate the shared cache with incomplete hook environments, forcing subsequent standard runs to reinstall dependencies without being able to update the cache on exact hits.

1 open issue

Review effort: Balanced

Comment thread .github/workflows/prek-manual.yml Resolved
jbampton commented Nov 9, 2026
View reviewed changes
Comment thread .github/workflows/prek.yml Resolved
Copilot AI balanced review requested due to automatic review settings November 9, 2026 04:40
jbampton commented Nov 9, 2026
View reviewed changes
Comment thread .github/workflows/prek-manual.yml Resolved
Copilot AI reviewed Nov 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🔵 Needs a closer look

Human assessment is needed because an unpublished workflow-concurrency finding indicates obsolete hook runs may compete with current checks for runner capacity.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 9, 2026 04:43
Copilot AI reviewed Nov 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🔵 Needs a closer look

Human review is needed to assess the runner-capacity impact of replacement workflows no longer canceling superseded PR runs.

No open issues 🎉

Review effort: Balanced

jbampton commented Nov 9, 2026
View reviewed changes
Comment thread .github/workflows/prek.yml Resolved
Copilot AI balanced review requested due to automatic review settings November 9, 2026 04:54
jbampton closed this Nov 9, 2026
Copilot AI reviewed Nov 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🟡 Changes recommended

The standard-hooks job fails before running any hooks because extra-args duplicates options already supplied by the pinned prek-action; use only --all-files or omit extra-args.

1 open issue

Review effort: Balanced

Comment thread .github/workflows/prek.yml
persist-credentials: false
- uses: j178/prek-action@44924fe9ef4a6f88253c4b6b1bf11c689d3ce53d # v3.1.0
with:
extra-args: --all-files --show-diff-on-failure --color=always
jbampton deleted the add-prek-action branch November 9, 2026 05:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

component:integration

Projects

None yet

Milestone

25.0

Development

Successfully merging this pull request may close these issues.

Switch from pre-commit to prek

3 participants

Back | FazBrowse Home | New Git URL