FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CKS: record a node's Kubernetes version, not the kubectl output by bhouse-nexthop · Pull Request #14635 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

CKS: record a node's Kubernetes version, not the kubectl output - #14635

Open
bhouse-nexthop wants to merge 1 commit into
apache:4.22from
bhouse-nexthop:cks-node-version-trim
ConversationCommits (1)ChecksFiles changed
Open

CKS: record a node's Kubernetes version, not the kubectl output#14635
bhouse-nexthop wants to merge 1 commit into
apache:4.22from
bhouse-nexthop:cks-node-version-trim

Conversation

bhouse-nexthop commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Description

After a node is upgraded, KubernetesClusterUtil.clusterNodeVersionMatches recorded the whole output of the SSH command that checks its version as the node's version: v1.33.1\n, plus anything the command wrote to stderr. listKubernetesClusters then returned kubernetesnodeversion with a v and a trailing newline for upgraded nodes, and without either for nodes created later, which record the semantic version.

This records the version that matched, which is the upgrade's semantic version, in the same form as for a new node.

Fixes #14629

Rows written before this change keep their old value. Nothing in CloudStack compares them; they are only returned by the API.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

New unit test in KubernetesClusterUtilTest: with the SSH command mocked to return v1.25.1\n, clusterNodeVersionMatches returns true and records 1.25.1. Without the fix it records v1.25.1\n. mvn -pl plugins/integrations/kubernetes-service -am test -Dtest=KubernetesClusterUtilTest passes.

The stored values in #14629 come from a test environment. This change itself has not been run against a live cluster.

How did you try to break this feature and the system with this change?

  • Only the value recorded after a match changes; the match itself doesn't.
  • A node that reports build metadata (v1.33.1+vendor.1) is recorded as the registered semantic version, the same as a new node.

CKS: record a node's Kubernetes version, not the kubectl output
2374017 
After a node is upgraded, the version recorded for it was the whole
output of the SSH command that checks it, such as "v1.33.1\n", and
whatever the command wrote to stderr. listKubernetesClusters then
returned kubernetesnodeversion with a "v" and a trailing newline for
upgraded nodes, and without either for nodes created later.

Record the version that matched, in the same form as for a new node.

Signed-off-by: Brad House <bhouse@nexthop.ai>

codecov Bot commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.32%. Comparing base (d02adcd) to head (2374017).

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #14635      +/-   ##
============================================
- Coverage     18.32%   18.32%   -0.01%     
  Complexity    16644    16644              
============================================
  Files          5939     5939              
  Lines        537768   537767       -1     
  Branches      65929    65929              
============================================
- Hits          98551    98547       -4     
- Misses       428008   428009       +1     
- Partials      11209    11211       +2
Flag Coverage Δ
uitests 4.08% <ø> (ø)
unittests 19.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bhouse-nexthop mentioned this pull request Nov 9, 2026
Open
3 of 12 tasks

bhouse-nexthop commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

Test report: node versions recorded by a CKS upgrade

Summary: after a Kubernetes upgrade, each upgraded node's recorded version is now the semantic version, 1.33.13. There's no v prefix and no trailing newline, the same form a new node gets. Before, the earlier upgrade of the same nodes had recorded v1.33.1\n.

Environment

Method: upgradeKubernetesCluster from v1.33.1 to v1.33.13. I read kubernetes_cluster_vm_map.kubernetes_node_version, with its hex, before and after, and kubernetesnodeversion from listKubernetesClusters.

Results

  • The upgrade succeeded (334 s); both nodes are Ready on v1.33.13.
  • Recorded versions: 
    before (written by the earlier upgrade, without this PR)
control-1   v1.33.1\n   76312E33332E310A
worker-1    v1.33.1\n   76312E33332E310A

after (written by this upgrade)
control-1   1.33.13     312E33332E3133
worker-1    1.33.13     312E33332E3133
  • The log line for each node gives the version that is stored: 
    20:35:14,834 DEBUG KubernetesClusterUtil  Updating node control-1 Kubernetes version to 1.33.13
20:36:26,546 DEBUG KubernetesClusterUtil  Updating node worker-1 Kubernetes version to 1.33.13
  • listKubernetesClusters returns "kubernetesnodeversion":"1.33.13" for both nodes.
  • For comparison, a worker added by a scale-up on the same build (the CKS: deploy nodes of a cluster created before 4.21 from the default template #14634 run) recorded 1.33.1. Upgraded and new nodes now use the same form.

Result: pass. An upgrade records the node's semantic version, not the command output.

Not covered

  • A node reporting build metadata (v1.33.1+vendor.1): the lab's ISOs don't have any. It is covered by the PR's reasoning only.
  • Rows written before this change keep their old value, as the PR says. The other two clusters in the lab still have v1.33.1\n.

bhouse-nexthop mentioned this pull request Nov 9, 2026
Open
3 of 12 tasks
DaanHoogland linked an issue Nov 11, 2026 that may be closed by this pull request
CKS: an upgrade records each node's Kubernetes version as raw kubectl output, with a leading v and a trailing newline #14629
Open
DaanHoogland added this to the 4.22.3 milestone Nov 11, 2026

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component:kubernetes

Projects

None yet

Milestone

4.22.3

Development

Successfully merging this pull request may close these issues.

CKS: an upgrade records each node's Kubernetes version as raw kubectl output, with a leading v and a trailing newline

2 participants

Back | FazBrowse Home | New Git URL