FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Restrict VDDK check on filesystem only when the agent property for VDDK is set by nvazquez · Pull Request #14688 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Restrict VDDK check on filesystem only when the agent property for VDDK is set - #14688

Open
nvazquez wants to merge 2 commits into
apache:4.22from
shapeblue:422-vddk-check-issue
ConversationCommits (2)ChecksFiles changed
Open

Restrict VDDK check on filesystem only when the agent property for VDDK is set#14688
nvazquez wants to merge 2 commits into
apache:4.22from
shapeblue:422-vddk-check-issue

Conversation

nvazquez commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR restricts the filesystem check for the VDDK library only when the property vddk.lib.dir is set on agent.properties

Fixes: #13497

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

nvazquez added this to the 4.22.2 milestone Nov 12, 2026
nvazquez linked an issue Nov 12, 2026 that may be closed by this pull request
Hosts get stuck in Alert state after update to cloudstack 4.22.1.0 #13497
Open
nvazquez mentioned this pull request Nov 12, 2026
Open

nvazquez commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Nov 12, 2026

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.32%. Comparing base (b56bbc2) to head (699f896).

Files with missing lines Patch % Lines
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.22   #14688   +/-   ##
=========================================
  Coverage     18.32%   18.32%           
+ Complexity    16644    16643    -1     
=========================================
  Files          5939     5939           
  Lines        537787   537777   -10     
  Branches      65932    65929    -3     
=========================================
- Hits          98544    98543    -1     
+ Misses       428033   428024    -9     
  Partials      11210    11210
Flag Coverage Δ
uitests 4.08% <ø> (ø)
unittests 19.41% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti approved these changes Nov 12, 2026
View reviewed changes

sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

blueorangutan commented Nov 12, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✖️ suse15. SL-JID 20021

nvazquez commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Nov 12, 2026

Copy link
Copy Markdown

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

timmyzhu commented Nov 12, 2026

Copy link
Copy Markdown

I'm not an official reviewer, but I do not believe this fixes the issue. It does not address the root cause, and I don't think it'll even workaround the issue. The root cause is the vddk detection is far too slow. Doing a search of the entire filesystem is not a good design and should be avoided. My recommendation would be to remove the detection, but I'm not a cloudstack developer or maintainer.

If there's no way to remove the detection or change the detection to not scan the entire root filesystem, then this change only addresses one of the calls to detectVddkLibDir. As noted in the bug report, there's another case where detectVddkLibDir is called in the hostSupportsVddk function, and I believe this will likely cause the bug to persist. Generally, calling a host supports function is not expected to take dozens of minutes, which would occur when the detectVddkLibDir function is called within the function. Within the hostSupportsVddk function, moving the hostSupportsInstanceConversion() function call from the return to the beginning of this function could potentially workaround this issue. At minimum, this should be included in this PR and tested that it's working as expected, but it doesn't address the design issue with the detection.

nvazquez commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @timmyzhu I have missed the check on hostSupportsVddk(), I have now removed it. Please have another review when possible

nvazquez commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Nov 12, 2026

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

timmyzhu commented Nov 12, 2026

Copy link
Copy Markdown

Thanks @nvazquez! I haven't tested anything, but from looking at the code, the PR appears to address and fix the root cause of #13497.

blueorangutan commented Nov 12, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20031

nvazquez commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Nov 12, 2026

Copy link
Copy Markdown

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Nov 13, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-17564)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 68930 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14688-t17564-kvm-ol8.zip
Smoke tests completed. 145 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_enableHumanReadableLogs Error 0.34 test_human_readable_logs.py
test_08_upgrade_kubernetes_ha_cluster Failure 848.35 test_kubernetes_clusters.py
test_01_primary_storage_nfs Error 0.26 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.43 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.17 test_primary_storage_scope.py

nvazquez commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Nov 13, 2026

Copy link
Copy Markdown

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Nov 13, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-17569)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 68168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14688-t17569-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_enableHumanReadableLogs Error 0.20 test_human_readable_logs.py
test_08_upgrade_kubernetes_ha_cluster Failure 3673.42 test_kubernetes_clusters.py
test_02_list_cpvm_vm Failure 0.04 test_ssvm.py
test_04_cpvm_internals Failure 0.06 test_ssvm.py

DaanHoogland approved these changes Nov 13, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
sureshanaparti sureshanaparti approved these changes
harikrishna-patnala Awaiting requested review from harikrishna-patnala
vladimirpetrov Awaiting requested review from vladimirpetrov
weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:kvm type:bug type:regression

Projects

None yet

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

Hosts get stuck in Alert state after update to cloudstack 4.22.1.0

5 participants

Back | FazBrowse Home | New Git URL