Quickly tested with 4.10 pre jdk8 and it work creating vm and resize the root volume on XenServer 6.5. tested using lvmiscsi and SolidFire storage plugins.

LGTM, but please answer pdube questions.

Thanks for this PR!

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-489

Hi @pdion891, @borisstoyanov, @anshul1886 and @pdube,
Thanks for your valuable suggestion and help.

@blueorangutan test centos7 vmware-65

@borisstoyanov unsupported parameters provided. Supported mgmt server os are: centos6, centos7, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-65sp1, xenserver-62sp1, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1

@blueorangutan test centos7 vmware-60u2

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests

@blueorangutan test centos7 xenserver-62sp1

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-62sp1) has been kicked to run smoke tests

Trillian test result (tid-827)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40945 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1813-t827-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Test completed. 45 look ok, 4 have error(s)

Trillian test result (tid-828)
Environment: xenserver-62sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42796 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1813-t828-xenserver-62sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 44 look ok, 5 have error(s)

@borisstoyanov Looks like some environmental issues with backend NFS. Can you kick it again for vmware ?

u'2017-02-15T20:21:38+0000', jobresult : {errorcode : 530, errortext : u'Failed to create templatecreate template from volume exception: Exception: java.lang.Exception\nMessage: unable to prepare template directory: template/tmpl/2/221, storage: NFS://10.2.0.16/acs/secondary/pr1813-t827-vmware-60u2/pr1813-t827-vmware-60u2-sec1, error msg: mkdir: cannot create directory \u2018/var/cloudstack/mnt/VM/7110653970250.2ffe4b26/template/tmpl/2/221\u2019: Permission denied\n'}, cmd :

@priyankparihar You need to adjust smoke test test_deploy_vm_root_resize.py to support vmware root resize. Otherwise it will keep failing

2017-02-15 12:48:59,150 - CRITICAL - FAILED: test_00_deploy_vm_root_resize: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n testMethod()\n', ' File "/marvin/tests/smoke/test_deploy_vm_root_resize.py", line 205, in test_00_deploy_vm_root_resize\n self.assertEqual(success, True, "Check if unsupported hypervisor %s fails appropriately" % self.hypervisor)\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n assertion_func(first, second, msg=msg)\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n raise self.failureException(msg)\n', 'AssertionError: Check if unsupported hypervisor vmware fails appropriately\n']

Thanks @priyankparihar @serg38
It takes about 6h to execute, can you guys look into resolving the issue with root resize tests and I'll rebuild then.

Hi @borisstoyanov and @serg38 ,
Test case is fixed. Please check. If anything is improper please notify.

--
Thanks :)

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-493

@blueorangutan test centos7 vmware-60u2

@blueorangutan test centos7 xenserver-65sp1

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests

@blueorangutan test centos7 vmware-60u2

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests

Trillian test result (tid-836)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38546 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1813-t836-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Test completed. 47 look ok, 2 have error(s)

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Hi @DaanHoogland Sir,

please do not merge this untill integration test runs have completely passed for all hypervisor types.

Yes, I am also on the same page.

I asked to merge it soon. Because some people have dependency on this code they want to make something good on top of this code. I was excited because i want to see these good features. My intention of 'Merge it soon' is just pay more attention on this PR. I am not saying to merge a code which does not pass all relevant test cases. Please do not take it in other way. Please do all kind of testing.

Thanks @priyankparihar , looking forward to the dependend PRs ;)
btw I don't agree with @borisstoyanov that every good feature PR should have a UI component, but it should have either a good one or none. (<-- IMNSHO)

Hi @borisstoyanov Bhai,

as a user I would expect to be able to do the changes from the Cloudstack console, not just the API

Yes, currently user can use this feature from Cloudstack console also.

please do not merge this untill integration test runs have completely passed for all hypervisor types.

I think @karuturi is one of the most reliable person of cloudstack. She would not merge without test case pass. Even if code is submitted by CS VIP like @chiradeep or @alex. :)

Hi @priyankparihar Bhai,
Sorry, I was referring to the user experience change I've suggested in the UI. I still think it's really good to have them.

Hi @borisstoyanov Bhai,

user experience change I've suggested in the UI

For that answer is already provided. Please consider it.

ACS CI BVT Run

Sumarry:
Build Number 585
Hypervisor xenserver
NetworkType Advanced
Passed=112
Failed=7
Skipped=6

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

• test_deploy_virtio_scsi_vm.py

• test_01_verify_libvirt Failing since 5 runs

• test_02_verify_libvirt_after_restart Failing since 5 runs

• test_03_verify_libvirt_attach_disk Failing since 5 runs

• test_04_verify_guest_lspci Failing since 5 runs

• test_05_change_vm_ostype_restart Failing since 5 runs

• test_06_verify_guest_lspci_again Failing since 5 runs

• ContextSuite context=TestDeployVirtioSCSIVM>:teardown Failing since 5 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

Trillian test result (tid-1037)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32543 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1813-t1037-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 48 look ok, 1 have error(s)

Trillian test result (tid-1036)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51805 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1813-t1036-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 45 look ok, 5 have error(s)

ACS CI BVT Run
Sumarry:
Build Number 585
Hypervisor xenserver
NetworkType Advanced
Passed=112
Failed=7
Skipped=6

Hi @koushik-das ,
All the tests inside 'test_deploy_virtio_scsi_vm.py' are failing. But it seems they related to KVM.

Only in case of VMware Root disk controller setting is checked (and checks are not reachable if hypervisor is not VMware). Same could be verified from the code. And this test is KVM related.

PS: @sadhugit ji: Do you want to add something ?

@priyankparihar these virtio errors are addressed in #2066

Hi @borisstoyanov,
I think whatever tests are failing they are failing because of some environment problem. I have tested few logs. I found error like -->

Trying SSH Connection: Host:10.1.34.224 User:root Port:22 RetryCnt:20=== SshClient: Exception under createConnection

failure type="exceptions.AssertionError" message="Check if promised disk size actually available

What is your opinion ?

@priyankparihar,
Here are the exceptions related to the tests and I think they are related to the latest changes in this PR:

test_deploy_vm_root_resize.py:
CRITICAL: EXCEPTION: None: [\'Traceback (most recent call last):\\n\', \' File "/usr/lib/python2.7/site-packages/nose/suite.py", line 209, in run\\n self.setUp()\\n\', \' File "/usr/lib/python2.7/site-packages/nose/suite.py", line 292, in setUp\\n self.setupContext(ancestor)\\n\', \' File "/usr/lib/python2.7/site-packages/nose/suite.py", line 315, in setupContext\\n try_run(context, names)\\n\', \' File "/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run\\n return func()\\n\', \' File "/marvin/tests/smoke/test_deploy_vm_root_resize.py", line 110, in setUpClass\\n domainid=cls.domain.id\\n\', \' File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1238, in register\\n "Unable to find Ostype is required for registering template")\\n\', \'Exception: Unable to find Ostype is required for registering template\\n\']

test_vm_snapshots.py:
2017-04-26 16:39:34,301 - CRITICAL - FAILED: test_01_test_vm_volume_snapshot: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n testMethod()\n', ' File "/marvin/tests/smoke/test_vm_snapshots.py", line 408, in test_01_test_vm_volume_snapshot\n volume_id=volume.id)\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 154, in __exit__\n "{0} not raised".format(exc_name))\n', 'AssertionError: Exception not raised\n']

test_volumes.py:
2017-04-26 17:18:13,947 - CRITICAL - FAILED: test_01_create_volume: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n testMethod()\n', ' File "/marvin/tests/smoke/test_volumes.py", line 251, in test_01_create_volume\n self.assertEqual(ret[0],SUCCESS,"Check if promised disk size actually available")\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n assertion_func(first, second, msg=msg)\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n raise self.failureException(msg)\n', 'AssertionError: Check if promised disk size actually available\n']

Checkout the vmware test run

@blueorangutan test centos7 xenserver-65sp1

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests

Trillian test result (tid-1046)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44603 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1813-t1046-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)