FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

listostypes: Fixes #2529 return boolean than string in response by yadvr · Pull Request #2632 · apache/cloudstack · GitHub

/ cloudstack Public

listostypes: Fixes #2529 return boolean than string in response - #2632

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:ui-html-api-fixes411
May 9, 2018
ConversationCommits (1)ChecksFiles changed
Merged

listostypes: Fixes #2529 return boolean than string in response#2632
yadvr merged 1 commit into
apache:4.11from
shapeblue:ui-html-api-fixes411

Conversation

yadvr commented May 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

This returns the boolean value of the isuserdefined key than
converting it to string. Fixes #2529.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

listostypes: Fixes apache#2529 return boolean than string in response
5ca3229 
This returns the boolean value of the `isuserdefined` key than
converting it to string. Fixes apache#2529.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added this to the 4.11.1.0 milestone May 9, 2018

yadvr commented May 9, 2018

Copy link
Copy Markdown
Member Author

I checked no smoke/component test consumes this API key, travis and packaging tests are enough to validate this change.
@blueorangutan package

yadvr mentioned this pull request May 9, 2018
Closed

blueorangutan commented May 9, 2018

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented May 9, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2037

resmo commented May 9, 2018

Copy link
Copy Markdown
Member

LGTM

nvazquez approved these changes May 9, 2018
View reviewed changes

nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

yadvr commented May 9, 2018

Copy link
Copy Markdown
Member Author

Merging this based on Travis smoke tests and reviews.

yadvr merged commit 253f7d7 into apache:4.11 May 9, 2018
psycofdj mentioned this pull request Aug 12, 2018
Closed
weizhouapache mentioned this pull request Oct 24, 2023
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

resmo resmo approved these changes
nvazquez nvazquez approved these changes
DaanHoogland Awaiting requested review from DaanHoogland
rafaelweingartner Awaiting requested review from rafaelweingartner

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

4.11.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL