FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rbd snapshot rollback by GabrielBrascher · Pull Request #3502 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Rbd snapshot rollback - #3502

Merged
yadvr merged 5 commits into
apache:masterfrom
CLDIN:rbd-snapshot-rollback
Jul 23, 2019
ConversationCommits (5)ChecksFiles changed
Merged

Rbd snapshot rollback#3502
yadvr merged 5 commits into
apache:masterfrom
CLDIN:rbd-snapshot-rollback

Conversation

GabrielBrascher commented Jul 18, 2019

Copy link
Copy Markdown
Member

Description

Add CephSnapshotStrategy to handle RBD revert (rollback) snapshot. In order to support RBD revert (rbd_rollback), this PR adds a CephSnapshotStrategy class to handle Ceph/RBD snapshot actions.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

(i) set snapshot.backup.to.secondary to false and restart ACS, ensuring that snapshots are stored directly on primary storage (Ceph/RBD)
(ii) create multiple snapshots with changes (e.g. new files) and stop the VM
(iii) revert to a given snapshot
(iv) assert that rbd_snap_rollback is successfuly executed (remote debug evaulating the code)
(v) start the VM and check that the VM disk content is as expected

GabrielBrascher added 3 commits July 11, 2019 18:55
Add CephSnapshotStrategy to handle RBD revert (rollback) snapshot
204d55c
Split the path to get volume and snapshot ids
67bc0d4 
The snapshotRelPath contains a string such as:
"poolName/volumeUuid/snapshotUuid"; thus, this commit splits the string
and retrieves the necessary data for open and rollback snapshot.
Enhancements and JUnit Tests
17509f0
GabrielBrascher added this to the 4.13.0.0 milestone Jul 18, 2019
GabrielBrascher self-assigned this Jul 18, 2019

GabrielBrascher commented Jul 18, 2019

Copy link
Copy Markdown
Member Author

This PR addresses issue #3498.

yadvr commented Jul 18, 2019

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Jul 18, 2019

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jul 18, 2019

Copy link
Copy Markdown

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-151

GabrielBrascher commented Jul 18, 2019

Copy link
Copy Markdown
Member Author

@rhtyd rados-java 0.5.0 should be pushed to Maven Central tonight; therefore we need to wait a few hours so we can reckick Travis and blueorangutan. I will ping when rados-java gets updated, thanks!

yadvr commented Jul 18, 2019

Copy link
Copy Markdown
Member

Okay @GabrielBrascher ping me when you want regression testing kicked.

wido commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

@rhtyd rados java 0.5.0 is in maven central now

yadvr commented Jul 19, 2019

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Jul 19, 2019

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jul 19, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-153

yadvr commented Jul 19, 2019

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Jul 19, 2019

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jul 19, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-154

yadvr commented Jul 22, 2019

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Jul 22, 2019

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Jul 22, 2019

Copy link
Copy Markdown

Trillian test result (tid-186)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29023 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3502-t186-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

yadvr commented Jul 22, 2019

Copy link
Copy Markdown
Member

Left a minor remark, tests also LGTM.
We can merge this as soon as any outstanding issues are fixed and we've another lgtm @GabrielBrascher

borisstoyanov approved these changes Jul 23, 2019
View reviewed changes

borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM based on test results

yadvr merged commit 6a511fc into apache:master Jul 23, 2019
yadvr mentioned this pull request Jul 23, 2019
Closed
GutoVeronezi mentioned this pull request Aug 23, 2021
Merged
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wido wido left review comments
yadvr yadvr approved these changes
borisstoyanov borisstoyanov approved these changes
mike-tutkowski Awaiting requested review from mike-tutkowski
rafaelweingartner Awaiting requested review from rafaelweingartner
DaanHoogland Awaiting requested review from DaanHoogland

Assignees

GabrielBrascher

Labels

component:ceph component:kvm type:new-feature

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL