FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Agent lb on svm by DaanHoogland · Pull Request #3795 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Agent lb on svm - #3795

Merged
andrijapanicsb merged 4 commits into
apache:4.13from
shapeblue:agentLbOnSvm
Jan 14, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Agent lb on svm#3795
andrijapanicsb merged 4 commits into
apache:4.13from
shapeblue:agentLbOnSvm

Conversation

DaanHoogland commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

Description

If a host is not in the list of hosts and an agent load balancing list is required for it, add it to the list to get a valid MSlist.

Fixes: #3722

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland changed the base branch from master to 4.13 January 6, 2020 12:13
apache deleted a comment from blueorangutan Jan 6, 2020

DaanHoogland commented Jan 6, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Jan 6, 2020

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

apache deleted a comment from blueorangutan Jan 6, 2020
apache deleted a comment from blueorangutan Jan 6, 2020

blueorangutan commented Jan 6, 2020

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-539

DaanHoogland commented Jan 6, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Jan 6, 2020

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Jan 7, 2020

Copy link
Copy Markdown

Trillian test result (tid-707)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37015 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3795-t707-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 276.27 test_vpc_vpn.py

yadvr requested review from nvazquez and yadvr January 7, 2020 06:52
yadvr added this to the 4.13.1.0 milestone Jan 7, 2020
yadvr approved these changes Jan 7, 2020
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, did not test it. Requested some changes.

yadvr commented Jan 7, 2020

Copy link
Copy Markdown
Member

@DaanHoogland replied, let me know if I've anything else.

DaanHoogland marked this pull request as ready for review January 7, 2020 14:13
DaanHoogland reopened this Jan 10, 2020

DaanHoogland commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

ping @andrijapanicsb this can do with a second pair of eyes and some tests

andrijapanicsb commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Jan 14, 2020

Copy link
Copy Markdown

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jan 14, 2020

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-595

andrijapanicsb commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tested manually by reproducing the issue on clean 4.13, confirming CPVM won't start with the exceptions below...:

2020-01-14 14:02:44,379 DEBUG [c.c.a.ConsoleProxyAlertAdapter] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) received console proxy alert
2020-01-14 14:02:44,380 DEBUG [c.c.a.ConsoleProxyAlertAdapter] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) Console proxy creation failure, zone: ref-trl-451-x-M7-apanic
2020-01-14 14:02:44,381 WARN [c.c.a.AlertManagerImpl] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) AlertType:: 10 | dataCenterId:: 1 | podId:: null | clusterId:: null | message:: Console proxy creation failure. zone: ref-trl-451-x-M7-apanic, error details: fromIndex = -1
2020-01-14 14:02:44,387 WARN [c.c.v.SystemVmLoadScanner] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) Unexpected exception fromIndex = -1
java.lang.IndexOutOfBoundsException: fromIndex = -1
at java.util.SubList.(AbstractList.java:620)
at java.util.RandomAccessSubList.(AbstractList.java:775)

Upgrade to this one, and CPVM starts fine (part of output below):

2020-01-14 14:35:16,100 DEBUG [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-1:ctx-a2d2a0b1 job-5/job-160 ctx-0562c679) (logid:8ae77e28) Successfully transitioned to start state for VM[ConsoleProxy|v-3-VM] reservation id = 44c9f85a-3c14-474f-93a6-8cfdd2fdc0d3

andrijapanicsb commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

LGTM

andrijapanicsb merged commit 6ebd02e into apache:4.13 Jan 14, 2020
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
Agent lb on svm (apache#3795)
3a23468 
* add host if needed

* allow for test with null-host

* full coverage of states

* EnumSet.contains instead of Arrays.binarySearch
yadvr mentioned this pull request Aug 12, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
andrijapanicsb andrijapanicsb approved these changes
nvazquez Awaiting requested review from nvazquez
borisstoyanov Awaiting requested review from borisstoyanov

Assignees

No one assigned

Labels

component:csvm component:ssvm type:bug

Projects

None yet

Milestone

4.13.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL