FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add missing HA config keys (#3776) by DaanHoogland · Pull Request #3814 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Add missing HA config keys (#3776) - #3814

Merged
DaanHoogland merged 3 commits into
masterfrom
ha-config-to-master
Jan 15, 2020
ConversationCommits (3)ChecksFiles changed
Merged

Add missing HA config keys (#3776)#3814
DaanHoogland merged 3 commits into
masterfrom
ha-config-to-master

Conversation

DaanHoogland commented Jan 14, 2020 •
edited by svenvogel
Loading

Copy link
Copy Markdown
Contributor

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland added this to the 4.14.0.0 milestone Jan 14, 2020

svenvogel commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

@DaanHoogland how it looks like?

DaanHoogland commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

@svenvogel it passed all tests on 4.13. it had merge conflict so i'll run tests again here.
@blueorangutan package

blueorangutan commented Jan 14, 2020

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jan 14, 2020

Copy link
Copy Markdown

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-596

DaanHoogland commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Jan 14, 2020

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jan 14, 2020

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-599

DaanHoogland commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Jan 14, 2020

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Jan 15, 2020

Copy link
Copy Markdown

Trillian test result (tid-771)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29028 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3814-t771-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 78 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

DaanHoogland commented Jan 15, 2020

Copy link
Copy Markdown
Contributor Author

@andrijapanicsb this is forward merged from the 4.13 branch and had LGTMs and tests. It had merge conflicts however but all looks fine now. merge?

andrijapanicsb commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

You know your stuff @DaanHoogland - so if you are happy, yes.

DaanHoogland changed the title Add missing HA config keys (#3776) Add missing HA config keys (#3776) Jan 15, 2020
DaanHoogland merged commit 4780a27 into master Jan 15, 2020
DaanHoogland deleted the ha-config-to-master branch January 15, 2020 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component:management-server type:bug type:enhancement

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL