FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

set TCP as default protocol in lb list by andrijapanicsb · Pull Request #3822 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

set TCP as default protocol in lb list - #3822

Merged
andrijapanicsb merged 1 commit into
masterfrom
TPC-as-default-protocol-in-LB-list
Jan 20, 2020
ConversationCommits (1)ChecksFiles changed
Merged

set TCP as default protocol in lb list#3822
andrijapanicsb merged 1 commit into
masterfrom
TPC-as-default-protocol-in-LB-list

Conversation

andrijapanicsb commented Jan 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Instead of "SSL" being set as a default LB protocol when configuring a LB rule, set TCP as the default one - move SSL to the bottom of the list.

Reason: SSL is supported only with NetScaller and should not even be there if VPC is not using NetScaller for LB services... so stop offering it as the default protocol and confusing VPC VR (i.e. non-NesScaller) users

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Old setup:

New setup:

andrijapanicsb commented Jan 19, 2020

Copy link
Copy Markdown
Contributor Author

Can be tested by downloading the patch file to mgmt server https://github.com/apache/cloudstack/commit/b9f39757506e0831ebcf015c408f6e93f7198c0d.patch
and applying a patch:

cd /usr/share/cloudstack-management/webapp/scripts
patch < b9f3975.patch
refresh the gui with ctrl +alt + R

andrijapanicsb added this to the 4.14.0.0 milestone Jan 19, 2020
andrijapanicsb self-assigned this Jan 19, 2020
yadvr approved these changes Jan 20, 2020
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, I'll incorporate the same in Primate as well.

DaanHoogland commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

@andrijapanicsb not for 4.13? (lgtm otherwise)

andrijapanicsb commented Jan 20, 2020

Copy link
Copy Markdown
Contributor Author

not in 4.13 as its not a bug fix @dahn.

Merging based on 2 LGTMs and manual testing. Automated testing not needed as this is a simple JS change.

andrijapanicsb merged commit a813c24 into master Jan 20, 2020
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
set TCP as default protocol in lb list (apache#3822)
fb80801
andrijapanicsb deleted the TPC-as-default-protocol-in-LB-list branch April 3, 2020 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
DaanHoogland Awaiting requested review from DaanHoogland
nvazquez Awaiting requested review from nvazquez
svenvogel Awaiting requested review from svenvogel

Assignees

andrijapanicsb

Labels

component:UI type:enhancement

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL