Repository navigation
Updated vmware virtual hardware version in systemvmtemplate build script - #3921
Merged
yadvr merged 2 commits intoMay 30, 2020
Merged
yadvr merged 2 commits into
yadvr merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
yadvr
requested changes
Feb 28, 2020
yadvr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Remove the shar archive script, lgtm
Sorry, something went wrong.
yadvr
approved these changes
Mar 3, 2020
Copy link
Copy Markdown
Member
|
This needs to be manually tested by building a new systemvmtemplate and then run test matrix manually using backend jenkins. This can wait until 4.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@DaanHoogland @harikrishna-patnala how about we merge this on master and continue work in the other PR? The change LGTM. |
Sorry, something went wrong.
DaanHoogland
approved these changes
May 30, 2020
DaanHoogland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull request updates the system VM template build script to use vmware hardware version 11 instead of 8.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
This was tested by running the build script before and after the change. No errors.