FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Hide cpuspeed for custom constrained offering by ustcweizhou · Pull Request #3996 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: Hide cpuspeed for custom constrained offering - #3996

Merged
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:4.13-ui-hide-cpuspeed-unconstrained-offering
Aug 28, 2020
ConversationCommits (1)ChecksFiles changed
Merged

UI: Hide cpuspeed for custom constrained offering#3996
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:4.13-ui-hide-cpuspeed-unconstrained-offering

Conversation

ustcweizhou commented Mar 27, 2020

Copy link
Copy Markdown
Contributor

Description

For customer constrained offering, the cpu speed is fixed.
Therefore the 'CpuSpeed' field should be hidden for customer constrained offering when change vm offering on UI.
It is visible only for unconstrained offering.

This is regression issue of #3245

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

yadvr commented Mar 30, 2020

Copy link
Copy Markdown
Member

cc @shwstppr @DaanHoogland @andrijapanicsb

shwstppr commented Mar 30, 2020

Copy link
Copy Markdown
Contributor

@ustcweizhou This is in vm deploy wizard?
I'm not able to reproduce any problem with 4.13 in UI.
CPU speed field is already hidden for Custom Constrained type offerings. Even after selecting an unconstrained offering then again selecting constrained offering. How to reproduce the problem?

weizhouapache commented Mar 30, 2020

Copy link
Copy Markdown
Member

@ustcweizhou This is in vm deploy wizard?
I'm not able to reproduce any problem with 4.13 in UI.
CPU speed field is already hidden for Custom Constrained type offerings. Even after selecting an unconstrained offering then again selecting constrained offering. How to reproduce the problem?

@shwstppr as I mentioned in the description, this issue happens when change vm offering.

yadvr added this to the 4.13.2.0 milestone Jun 11, 2020
yadvr changed the base branch from 4.13 to 4.14 August 28, 2020 09:07
yadvr modified the milestones: 4.13.2.0, 4.14.1.0 Aug 28, 2020
yadvr changed the base branch from 4.14 to 4.13 August 28, 2020 09:07
yadvr modified the milestones: 4.14.1.0, 4.13.2.0 Aug 28, 2020

yadvr commented Aug 28, 2020

Copy link
Copy Markdown
Member

Since this is a UI only change no smoketests are necessary. All new changes are in Primate now, legacy UI need not be maintained anymore.
LGTM, I'll merge on 4.13 and fwd merge on 4.14 and master.

shwstppr approved these changes Aug 28, 2020
View reviewed changes

shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM based on code changes

yadvr merged commit ba4b04f into apache:4.13 Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
shwstppr shwstppr approved these changes

Assignees

No one assigned

Labels

component:UI Severity:Minor type:bug type:regression

Projects

None yet

Milestone

4.13.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL